-
-
Notifications
You must be signed in to change notification settings - Fork 559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ci): support pkg.pr.new #7757
Merged
SoonIter
merged 6 commits into
web-infra-dev:main
from
shulaoda:chore/support-pkg-pr-new
Sep 29, 2024
Merged
chore(ci): support pkg.pr.new #7757
SoonIter
merged 6 commits into
web-infra-dev:main
from
shulaoda:chore/support-pkg-pr-new
Sep 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rspack canceled.Built without sensitive environment variables
|
shulaoda
force-pushed
the
chore/support-pkg-pr-new
branch
6 times, most recently
from
September 3, 2024 15:39
adaf3ef
to
038081d
Compare
This was referenced Sep 3, 2024
shulaoda
force-pushed
the
chore/support-pkg-pr-new
branch
15 times, most recently
from
September 9, 2024 12:49
8583be7
to
6bc980c
Compare
Could you check https://github.com/apps/pkg-pr-new again? @chenjiahan Run npx pkg-pr-new publish --compact --pnpm './npm/*' './crates/node_binding' './packages/rspack'
{"url":"/check","statusCode":404,"statusMessage":"Not Found","message":"The app https://github.com/apps/pkg-pr-new is not installed on web-infra-dev/rspack."}
Error: Process completed with exit code 1. |
@shulaoda I just reinstalled the app, can you try again? |
shulaoda
force-pushed
the
chore/support-pkg-pr-new
branch
from
September 10, 2024 03:46
15e4e95
to
6bc980c
Compare
shulaoda
force-pushed
the
chore/support-pkg-pr-new
branch
2 times, most recently
from
September 26, 2024 12:19
0e4f20a
to
a7b0fa6
Compare
@rspack/binding
@rspack/binding-darwin-x64
@rspack/binding-darwin-arm64
@rspack/binding-linux-arm64-gnu
@rspack/binding-linux-arm64-musl
@rspack/binding-linux-x64-gnu
@rspack/binding-linux-x64-musl
@rspack/binding-win32-arm64-msvc
@rspack/binding-win32-ia32-msvc
@rspack/binding-win32-x64-msvc
@rspack/core
commit: |
ready now |
SoonIter
reviewed
Sep 27, 2024
SoonIter
reviewed
Sep 27, 2024
shulaoda
force-pushed
the
chore/support-pkg-pr-new
branch
from
September 27, 2024 08:25
d8d09de
to
da55ff9
Compare
shulaoda
force-pushed
the
chore/support-pkg-pr-new
branch
3 times, most recently
from
September 28, 2024 12:13
9996f24
to
70ad264
Compare
shulaoda
force-pushed
the
chore/support-pkg-pr-new
branch
2 times, most recently
from
September 29, 2024 01:36
5c6ab4c
to
282c600
Compare
This was referenced Sep 29, 2024
SoonIter
approved these changes
Sep 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Awesome 👍🏻 |
This was referenced Sep 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
closes #7754
Checklist