Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): support pkg.pr.new #7757

Merged
merged 6 commits into from
Sep 29, 2024

Conversation

shulaoda
Copy link
Collaborator

@shulaoda shulaoda commented Sep 2, 2024

Summary

closes #7754

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Sep 2, 2024

Deploy Preview for rspack canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit 282c600
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/66f8af1da50ffc0008136a94

@shulaoda shulaoda marked this pull request as draft September 2, 2024 07:07
@shulaoda shulaoda force-pushed the chore/support-pkg-pr-new branch 6 times, most recently from adaf3ef to 038081d Compare September 3, 2024 15:39
@shulaoda shulaoda force-pushed the chore/support-pkg-pr-new branch 15 times, most recently from 8583be7 to 6bc980c Compare September 9, 2024 12:49
@shulaoda
Copy link
Collaborator Author

shulaoda commented Sep 10, 2024

Could you check https://github.com/apps/pkg-pr-new again? @chenjiahan

Run npx pkg-pr-new publish --compact --pnpm './npm/*' './crates/node_binding' './packages/rspack'
{"url":"/check","statusCode":404,"statusMessage":"Not Found","message":"The app https://github.com/apps/pkg-pr-new is not installed on web-infra-dev/rspack."}
Error: Process completed with exit code 1.

@chenjiahan
Copy link
Member

@shulaoda I just reinstalled the app, can you try again?

image

@shulaoda shulaoda force-pushed the chore/support-pkg-pr-new branch 2 times, most recently from 0e4f20a to a7b0fa6 Compare September 26, 2024 12:19
Copy link

pkg-pr-new bot commented Sep 26, 2024

Open in Stackblitz

@rspack/binding

pnpm add https://pkg.pr.new/@rspack/binding@7757

@rspack/binding-darwin-x64

pnpm add https://pkg.pr.new/@rspack/binding-darwin-x64@7757

@rspack/binding-darwin-arm64

pnpm add https://pkg.pr.new/@rspack/binding-darwin-arm64@7757

@rspack/binding-linux-arm64-gnu

pnpm add https://pkg.pr.new/@rspack/binding-linux-arm64-gnu@7757

@rspack/binding-linux-arm64-musl

pnpm add https://pkg.pr.new/@rspack/binding-linux-arm64-musl@7757

@rspack/binding-linux-x64-gnu

pnpm add https://pkg.pr.new/@rspack/binding-linux-x64-gnu@7757

@rspack/binding-linux-x64-musl

pnpm add https://pkg.pr.new/@rspack/binding-linux-x64-musl@7757

@rspack/binding-win32-arm64-msvc

pnpm add https://pkg.pr.new/@rspack/binding-win32-arm64-msvc@7757

@rspack/binding-win32-ia32-msvc

pnpm add https://pkg.pr.new/@rspack/binding-win32-ia32-msvc@7757

@rspack/binding-win32-x64-msvc

pnpm add https://pkg.pr.new/@rspack/binding-win32-x64-msvc@7757

@rspack/core

pnpm add https://pkg.pr.new/@rspack/core@7757

commit: a7b0fa6

@shulaoda shulaoda marked this pull request as ready for review September 26, 2024 13:21
@shulaoda
Copy link
Collaborator Author

is it ready?

ready now

@shulaoda shulaoda force-pushed the chore/support-pkg-pr-new branch 3 times, most recently from 9996f24 to 70ad264 Compare September 28, 2024 12:13
@shulaoda shulaoda marked this pull request as draft September 28, 2024 14:08
@shulaoda shulaoda force-pushed the chore/support-pkg-pr-new branch 2 times, most recently from 5c6ab4c to 282c600 Compare September 29, 2024 01:36
@shulaoda shulaoda marked this pull request as ready for review September 29, 2024 01:36
Copy link
Member

@SoonIter SoonIter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SoonIter SoonIter merged commit b2ee5d1 into web-infra-dev:main Sep 29, 2024
30 checks passed
@chenjiahan
Copy link
Member

Awesome 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Support for pkg.pr.new
4 participants