Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: remove io and time driver #8391

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

perf: remove io and time driver #8391

wants to merge 3 commits into from

Conversation

hardfist
Copy link
Contributor

Summary

we don't use io&time driver, so remove it can save us some time

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@hardfist
Copy link
Contributor Author

!bench

Copy link

netlify bot commented Nov 11, 2024

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 30a1955
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/6731870b7c5678000892bd55

@github-actions github-actions bot added release: performance release: performance related release(mr only) team The issue/pr is created by the member of Rspack. labels Nov 11, 2024
@rspack-bot
Copy link

rspack-bot commented Nov 11, 2024

📝 Benchmark detail: Open

Name Base (2024-11-11 2ac4a11) Current Change
10000_big_production-mode + exec 44.3 s ± 799 ms 44.5 s ± 825 ms +0.52 %
10000_development-mode + exec 1.85 s ± 27 ms 1.83 s ± 14 ms -0.98 %
10000_development-mode_hmr + exec 642 ms ± 6.8 ms 645 ms ± 7.2 ms +0.41 %
10000_production-mode + exec 2.44 s ± 34 ms 2.43 s ± 23 ms -0.40 %
arco-pro_development-mode + exec 1.78 s ± 79 ms 1.79 s ± 76 ms +1.08 %
arco-pro_development-mode_hmr + exec 430 ms ± 0.53 ms 431 ms ± 1.7 ms +0.03 %
arco-pro_production-mode + exec 3.17 s ± 72 ms 3.2 s ± 84 ms +0.87 %
arco-pro_production-mode_generate-package-json-webpack-plugin + exec 3.24 s ± 79 ms 3.23 s ± 79 ms -0.20 %
threejs_development-mode_10x + exec 1.58 s ± 13 ms 1.58 s ± 27 ms -0.28 %
threejs_development-mode_10x_hmr + exec 774 ms ± 12 ms 778 ms ± 7.2 ms +0.58 %
threejs_production-mode_10x + exec 4.96 s ± 35 ms 4.96 s ± 18 ms -0.07 %

@hardfist
Copy link
Contributor Author

!bench

@rspack-bot
Copy link

rspack-bot commented Nov 11, 2024

📝 Benchmark detail: Open

Name Base (2024-11-11 2ac4a11) Current Change
10000_big_production-mode + exec 44.3 s ± 799 ms 44.1 s ± 893 ms -0.47 %
10000_development-mode + exec 1.85 s ± 27 ms 1.83 s ± 16 ms -1.25 %
10000_development-mode_hmr + exec 642 ms ± 6.8 ms 643 ms ± 6.9 ms +0.15 %
10000_production-mode + exec 2.44 s ± 34 ms 2.43 s ± 27 ms -0.21 %
arco-pro_development-mode + exec 1.78 s ± 79 ms 1.77 s ± 59 ms -0.55 %
arco-pro_development-mode_hmr + exec 430 ms ± 0.53 ms 431 ms ± 1.9 ms +0.04 %
arco-pro_production-mode + exec 3.17 s ± 72 ms 3.21 s ± 65 ms +1.16 %
arco-pro_production-mode_generate-package-json-webpack-plugin + exec 3.24 s ± 79 ms 3.26 s ± 73 ms +0.79 %
threejs_development-mode_10x + exec 1.58 s ± 13 ms 1.58 s ± 12 ms -0.14 %
threejs_development-mode_10x_hmr + exec 774 ms ± 12 ms 774 ms ± 10 ms +0.06 %
threejs_production-mode_10x + exec 4.96 s ± 35 ms 4.97 s ± 19 ms +0.19 %

@hardfist
Copy link
Contributor Author

!bench

@rspack-bot
Copy link

rspack-bot commented Nov 11, 2024

📝 Benchmark detail: Open

Name Base (2024-11-11 2ac4a11) Current Change
10000_big_production-mode + exec 44.3 s ± 799 ms 45.2 s ± 1.18 s +2.06 %
10000_development-mode + exec 1.85 s ± 27 ms 2.56 s ± 71 ms +38.33 %
10000_development-mode_hmr + exec 642 ms ± 6.8 ms 652 ms ± 8.4 ms +1.51 %
10000_production-mode + exec 2.44 s ± 34 ms 3.12 s ± 66 ms +27.98 %
arco-pro_development-mode + exec 1.78 s ± 79 ms 1.94 s ± 90 ms +9.33 %
arco-pro_development-mode_hmr + exec 430 ms ± 0.53 ms 431 ms ± 0.8 ms +0.14 %
arco-pro_production-mode + exec 3.17 s ± 72 ms 3.38 s ± 83 ms +6.76 %
arco-pro_production-mode_generate-package-json-webpack-plugin + exec 3.24 s ± 79 ms 3.4 s ± 100 ms +5.02 %
threejs_development-mode_10x + exec 1.58 s ± 13 ms 1.76 s ± 24 ms +11.04 %
threejs_development-mode_10x_hmr + exec 774 ms ± 12 ms 782 ms ± 6.8 ms +1.07 %
threejs_production-mode_10x + exec 4.96 s ± 35 ms 5.15 s ± 33 ms +3.73 %

Threshold exceeded: ["10000_development-mode + exec","10000_production-mode + exec","arco-pro_development-mode + exec","arco-pro_production-mode + exec","arco-pro_production-mode_generate-package-json-webpack-plugin + exec","threejs_development-mode_10x + exec"]

@hardfist
Copy link
Contributor Author

!bench

@rspack-bot
Copy link

rspack-bot commented Nov 14, 2024

📝 Benchmark detail: Open

Name Base (2024-11-14 710908b) Current Change
10000_big_production-mode + exec 44.6 s ± 902 ms 45.9 s ± 929 ms +2.88 %
10000_development-mode + exec 1.79 s ± 26 ms 2.55 s ± 55 ms +42.62 %
10000_development-mode_hmr + exec 645 ms ± 14 ms 646 ms ± 6.3 ms +0.24 %
10000_production-mode + exec 2.43 s ± 31 ms 3.1 s ± 62 ms +27.69 %
arco-pro_development-mode + exec 1.78 s ± 54 ms 1.91 s ± 75 ms +7.33 %
arco-pro_development-mode_hmr + exec 430 ms ± 1.1 ms 431 ms ± 2.4 ms +0.43 %
arco-pro_production-mode + exec 3.17 s ± 33 ms 3.36 s ± 75 ms +5.99 %
arco-pro_production-mode_generate-package-json-webpack-plugin + exec 3.22 s ± 87 ms 3.38 s ± 72 ms +5.11 %
threejs_development-mode_10x + exec 1.58 s ± 9.6 ms 1.76 s ± 25 ms +10.98 %
threejs_development-mode_10x_hmr + exec 780 ms ± 13 ms 783 ms ± 14 ms +0.48 %
threejs_production-mode_10x + exec 4.97 s ± 32 ms 5.13 s ± 27 ms +3.22 %

Threshold exceeded: ["10000_development-mode + exec","10000_production-mode + exec","arco-pro_development-mode + exec","arco-pro_production-mode + exec","arco-pro_production-mode_generate-package-json-webpack-plugin + exec","threejs_development-mode_10x + exec"]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: performance release: performance related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants