Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement output.clean.keep: Option<string> #8479

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ClSlaid
Copy link

@ClSlaid ClSlaid commented Nov 19, 2024

Summary

Part of #7822

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Signed-off-by: cl <cailue@apache.org>
@CLAassistant
Copy link

CLAassistant commented Nov 19, 2024

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the release: feature release: feature related release(mr only) label Nov 19, 2024
Copy link

netlify bot commented Nov 19, 2024

Deploy Preview for rspack ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit be23764
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/673ce790a78c840008735a8a
😎 Deploy Preview https://deploy-preview-8479--rspack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ClSlaid
Copy link
Author

ClSlaid commented Nov 20, 2024

/cc @h-a-n-a I wonder where I can add tests?

@inottn
Copy link
Collaborator

inottn commented Nov 20, 2024

You can write test cases under packages/rspack-test-tools/tests/configCases/clean/ignore-string.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: feature release: feature related release(mr only)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants