Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): fix writeSearchIndex function use userConfig instead modifiedConfig #1376

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

liuwenzhuang
Copy link
Contributor

problem: dev command make search_index.json write to default outDir when outDir is set in plugin, when search trigger, dev server will halt because search_index.json not exists in final outDir.

Summary

Related Issue

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

…iedConfig

problem: dev command make search_index.json write to default outDir when outDir is set in plugin, when search trigger, dev server will halt because search_index.json not exists in final outDir.
@CLAassistant
Copy link

CLAassistant commented Sep 2, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

netlify bot commented Sep 2, 2024

Deploy Preview for aquamarine-blini-95325f ready!

Name Link
🔨 Latest commit ac0c809
🔍 Latest deploy log https://app.netlify.com/sites/aquamarine-blini-95325f/deploys/66d52400bdc8ba0008d1b302
😎 Deploy Preview https://deploy-preview-1376--aquamarine-blini-95325f.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 95 (🟢 up 22 from production)
Accessibility: 97 (no change from production)
Best Practices: 92 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@Timeless0911 Timeless0911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@Timeless0911 Timeless0911 enabled auto-merge (squash) September 2, 2024 03:19
@Timeless0911 Timeless0911 merged commit 6a7688e into web-infra-dev:main Sep 2, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants