Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(theme-default): adjust the color contrast in dark mode #1447

Merged

Conversation

yuyutaotao
Copy link
Contributor

Summary

Improve the color contrast of default theme in dark mode.

According to WebAIM, the default color contrast for Rspress is low at 11, which makes the docs difficult to read. Here I changed the default theme color to improve the contrast ratio to 16.

Here i changed the default theme color to improve the contrast to 16.

image

Some data for reference:

Site Contrast (by WebAIM)
NextJS 17.93
ReactJS 13.95
Rspress (before this PR) 11.65
Rspress (after this PR) 16.9

CleanShot 2024-10-08 at 14 57 04@2x

CleanShot 2024-10-08 at 14 57 16@2x

Related Issue

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Oct 8, 2024

Deploy Preview for aquamarine-blini-95325f ready!

Name Link
🔨 Latest commit 1ce196f
🔍 Latest deploy log https://app.netlify.com/sites/aquamarine-blini-95325f/deploys/6704dc95922a290008a96c5e
😎 Deploy Preview https://deploy-preview-1447--aquamarine-blini-95325f.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 94 (🟢 up 12 from production)
Accessibility: 97 (no change from production)
Best Practices: 92 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@Timeless0911
Copy link
Contributor

image
LGTM

Copy link
Member

@chenjiahan chenjiahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@chenjiahan chenjiahan merged commit 16f268d into web-infra-dev:main Oct 8, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants