Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(perf): remove the _html size in runtime module #1478

Merged
merged 1 commit into from
Oct 15, 2024
Merged

Conversation

SoonIter
Copy link
Member

@SoonIter SoonIter commented Oct 15, 2024

Summary

Related Issue

closes: #1475

#1472

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Oct 15, 2024

Deploy Preview for aquamarine-blini-95325f ready!

Name Link
🔨 Latest commit 1d6b734
🔍 Latest deploy log https://app.netlify.com/sites/aquamarine-blini-95325f/deploys/670dea3a30627e0008998b44
😎 Deploy Preview https://deploy-preview-1478--aquamarine-blini-95325f.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 96 (🟢 up 5 from production)
Accessibility: 97 (no change from production)
Best Practices: 92 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@SoonIter SoonIter changed the title perf: remove the _html size in runtime module fix(perf): remove the _html size in runtime module Oct 15, 2024
@SoonIter SoonIter requested a review from Timeless0911 October 15, 2024 04:08
@Timeless0911
Copy link
Contributor

!bench

@rspack-bot
Copy link

rspack-bot commented Oct 15, 2024

📝 Benchmark detail: Open

case: rspress-website
base: bb732e8
current: 1d6b734f

Metric Base Current %
beforeDevTime 0.81s 0.81s +0.17%
routeGenerateTime 0.02s 0.02s +2.52%
devColdBootTime 1.41s 1.39s -1.72%
initialJsSize 885.68KB 525.55KB -40.66%
gzipInitialJsSize 249.09KB 162.82KB -34.64%
buildColdBootTime 1.42s 1.37s -3.27%
beforeBuildTime 0.83s 0.84s +1.49%
minifiedBundleSize 6283.77KB 5923.65KB -5.73%
gzippedBundleSize 1130.54KB 1044.1KB -7.65%
coldInstallTime 39.02s 70.78s +81.37%
hotInstallTime 0.34s 0.34s +0.19%
dependenciesCount 553 553 0.00%
installSize 217.42MB 217.05MB -0.17%

@SoonIter SoonIter enabled auto-merge (squash) October 15, 2024 05:44
@SoonIter SoonIter merged commit bc68277 into main Oct 15, 2024
11 checks passed
@SoonIter SoonIter deleted the perf/size branch October 15, 2024 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Benchmark Performance Degradation (2024-10-15)
3 participants