Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugin-api-docgen): search index should include generated API doc #1716

Merged
merged 3 commits into from
Dec 27, 2024

Conversation

SoonIter
Copy link
Member

@SoonIter SoonIter commented Dec 27, 2024

Summary

Regex was used incorrectly.

const apiCompRegExp =
/(<API\s+moduleName=['"](\S+)['"]\s*(.*)?\/>)|(<API\s+moduleName=['"](\S+)['"]\s*(.*)?>(.*)?<\/API>)/;
await Promise.all(

Related Issue

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Dec 27, 2024

Deploy Preview for aquamarine-blini-95325f ready!

Name Link
🔨 Latest commit e544785
🔍 Latest deploy log https://app.netlify.com/sites/aquamarine-blini-95325f/deploys/676e704b9a0eb6000849b4b7
😎 Deploy Preview https://deploy-preview-1716--aquamarine-blini-95325f.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 86 (🔴 down 2 from production)
Accessibility: 97 (no change from production)
Best Practices: 92 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@Timeless0911 Timeless0911 merged commit 3a00050 into main Dec 27, 2024
7 checks passed
@Timeless0911 Timeless0911 deleted the fix-api-docgen branch December 27, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants