Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds JS Date object #1561

Merged
merged 10 commits into from
Aug 19, 2024
Merged

Adds JS Date object #1561

merged 10 commits into from
Aug 19, 2024

Conversation

petele
Copy link
Collaborator

@petele petele commented Aug 8, 2024

No description provided.

@github-actions github-actions bot added the feature definition Creating or defining new features or groups of features. label Aug 8, 2024
@petele
Copy link
Collaborator Author

petele commented Aug 8, 2024

Note: I did not remove the Date methods from features/draft/spec/ecmascript.yml - can do that if its not automatically updated.

@foolip
Copy link
Collaborator

foolip commented Aug 9, 2024

Note: I did not remove the Date methods from features/draft/spec/ecmascript.yml - can do that if its not automatically updated.

No need. #1568 should get the updater workflow running.

foolip
foolip reviewed Aug 9, 2024
View reviewed changes
features/date.yml.dist Outdated Show resolved Hide resolved
ddbeck
ddbeck reviewed Aug 12, 2024
View reviewed changes
features/date.yml Outdated Show resolved Hide resolved
@petele petele requested a review from ddbeck August 13, 2024 14:41
@petele
Copy link
Collaborator Author

petele commented Aug 13, 2024

@ddbeck - updated with group, ready to go.

ddbeck
ddbeck requested changes Aug 16, 2024
View reviewed changes
features/date.yml Outdated Show resolved Hide resolved
petele and others added 2 commits August 16, 2024 09:27
@petele @ddbeck
Update features/date.yml
9e54a67 
Co-authored-by: Daniel D. Beck <daniel@ddbeck.com>
@petele
Merge branch 'main' into date-obj
2a5aafd
@petele petele requested a review from ddbeck August 16, 2024 13:27
@ddbeck
Copy link
Collaborator

ddbeck commented Aug 19, 2024

Thank you, Pete!

@ddbeck ddbeck merged commit 2d06cd0 into web-platform-dx:main Aug 19, 2024
3 checks passed
@petele petele deleted the date-obj branch August 19, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@foolip foolip foolip left review comments

@ddbeck ddbeck ddbeck approved these changes

@Elchi3 Elchi3 Elchi3 approved these changes

Assignees
No one assigned
Labels
feature definition Creating or defining new features or groups of features.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@petele @foolip @ddbeck @Elchi3