Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New writingsuggestions feature #1579

Merged
merged 6 commits into from
Aug 21, 2024
Merged

New writingsuggestions feature #1579

merged 6 commits into from
Aug 21, 2024

Conversation

captainbrosset
Copy link
Contributor

See:

The feature lets devs control which fields (or parts of a webpage) should have the browser-provided writing suggestions/completions turned on or off.

I'm adding MDN docs for it at mdn/content#35445.

The BCD daeta for this landed in mdn/browser-compat-data#24121, which we don't yet have here in the repo, so generating a dist file isn't yet possible.

@github-actions github-actions bot added the feature definition Creating or defining new features or groups of features. label Aug 13, 2024
@ddbeck ddbeck added the blocked Blocked waiting for something external label Aug 13, 2024
features/writingsuggestions.yml Outdated Show resolved Hide resolved
features/writingsuggestions.yml Show resolved Hide resolved
Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more round on the description. Also I think you can merge main into this branch now and generate a useful dist.

features/writingsuggestions.yml Outdated Show resolved Hide resolved
@captainbrosset
Copy link
Contributor Author

captainbrosset commented Aug 21, 2024

I'm still seeing html.global_attributes.writingsuggestions is unindexable at 'writingsuggestions' after updating from main and running npm install. We use BCD 5.5.46, but looks like 5.5.47 is now available, we need to bump to get html.global_attributes.writingsuggestions. Edit: I see this is happening in #1640.

Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Patrick!

@ddbeck ddbeck merged commit 8c0f604 into main Aug 21, 2024
3 checks passed
@ddbeck ddbeck deleted the writingsuggestions branch August 21, 2024 12:28
@ddbeck ddbeck removed the blocked Blocked waiting for something external label Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature definition Creating or defining new features or groups of features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants