Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Symbol #1669

Merged
merged 3 commits into from
Oct 9, 2024
Merged

Add Symbol #1669

merged 3 commits into from
Oct 9, 2024

Conversation

Elchi3
Copy link
Collaborator

@Elchi3 Elchi3 commented Aug 26, 2024

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Symbol

I've used compute_from as the late-additions are all baseline high for quite a while as well and probably not too exciting (anymore) for them to be their own features.

@github-actions github-actions bot added the feature definition Creating or defining new features or groups of features. label Aug 26, 2024
@@ -0,0 +1,28 @@
name: Symbol
description: The `Symbol` type represents a unique identifier.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heh, super abstract concept, but seems like this could use either more descriptiveness or an example, or both.

features/symbol.yml Outdated Show resolved Hide resolved
Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to get this in today, so I'm going to merge this and open a PR with my own description suggestion. 🙂

@ddbeck ddbeck dismissed autonome’s stale review October 9, 2024 18:42

Continuing description in another PR

@ddbeck ddbeck merged commit e2087d9 into web-platform-dx:main Oct 9, 2024
3 checks passed
ddbeck added a commit to ddbeck/web-features that referenced this pull request Oct 9, 2024
ddbeck added a commit to ddbeck/web-features that referenced this pull request Oct 9, 2024
@Elchi3 Elchi3 deleted the symbols branch October 9, 2024 20:44
Elchi3 pushed a commit that referenced this pull request Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature definition Creating or defining new features or groups of features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants