Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add streams #990

Merged
merged 3 commits into from
Apr 29, 2024
Merged

Add streams #990

merged 3 commits into from
Apr 29, 2024

Conversation

ddbeck
Copy link
Collaborator

@ddbeck ddbeck commented Apr 29, 2024

This is only partly finished. Questions abound:

  • Are streams, in the abstract, a feature? Caniuse has one for it, so I assume yes, but maybe I'm wrong.
  • Is BYOB a core part of this? Caniuse says yes but it seems like developers are using streams without this.
  • Is api.WritableStreamDefaultController.signal a distinct thing, like abortable fetch?

@ddbeck ddbeck requested a review from foolip April 29, 2024 12:27
@github-actions github-actions bot added the feature definition Creating or defining new features or groups of features. label Apr 29, 2024
@ddbeck ddbeck mentioned this pull request Apr 29, 2024
32 tasks
baseline: low
baseline_low_date: 2023-03-27
support:
chrome: "98"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Matching https://caniuse.com/streams fully here doesn't feel like an option, but I think we can decide which notes we consider for our "initial support" feature.

I would say that note 2 (Only basic read support) and 4 (No support for WritableStream) do warrant partial implementation, because just reading or just writing means that streams is being used as part of some other feature, I can't see how it could be used standalone without at least write and write support.

BYOB support however I think we should consider not a part of the initial feature.

All in all, I'd expect these versions to fall out, assuming caniuse data is correct:

  • Chrome 59
  • Firefox 100
  • Safari 14.1

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, got it. We can't exactly match that with BCD (I suspect because caniuse doesn't note the missing WritableStream interface in Safari before 14.5), but we can get pretty close. See the latest diff.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ddbeck! Merged!

@foolip foolip merged commit 7861eac into web-platform-dx:main Apr 29, 2024
3 checks passed
@ddbeck ddbeck deleted the streams branch April 29, 2024 17:10
@foolip foolip mentioned this pull request May 22, 2024
32 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature definition Creating or defining new features or groups of features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants