-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove /css/css-flexbox/flexbox-align-self-baseline-horiz-008.xhtml from Interop 2023 #320
Comments
@jgraham can you review this for Gecko? @gsnedders @nt1m can you review this for WebKit? |
Is it possible to replace with But yeah, I agree we shouldn't have tests relying on sideways WM for Interop 2023 |
That's kind of covered by http://wpt.live/css/css-flexbox/flexbox-align-self-baseline-horiz-006.xhtml . I say "kind of" because 006 is about orthogonal children, not where the whole container is in a vertical writing mode. Other than that, there isn't a straight translation of flexbox-align-self-baseline-horiz-008.xhtml for vertical writing modes. Switching to vertical writing mode SGTM. |
@davidsgrogan is the conclusion to update this test instead of removing it? |
Sorry, I'm new to the process... does the process require input from all 3 engines before there can BE a conclusion? (Haven't heard from gecko yet.) |
This test should just be excluded rather than changing. The test is valuable for implementations which implement the sideways variant, and we shouldn't decrease their test coverage to make a number go up. :). Ian |
+1 to Ian. The more I thought about it I agree that we shouldn't change the test... it is a totally valid test as is, it just covers an area we're not doing this year. |
that seems fine too |
I've prepared web-platform-tests/wpt-metadata#4156. @jgraham WDYT? |
@emilio Does removing this test seem reasonable? |
Seems reasonable |
Cool, we have enough support for this now, I'll land web-platform-tests/wpt-metadata#4156. |
Test List
https://wpt.fyi/results/css/css-flexbox/flexbox-align-self-baseline-horiz-008.xhtml?label=experimental&label=master&product=chrome&product=firefox&product=safari&aligned&view=subtest
Rationale
Relies on having implemented
writing-mode: sideways-rl;
, a feature that neither Webkit nor Blink have shipped, and isn't part of Interop 2023.The text was updated successfully, but these errors were encountered: