Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove /css/css-flexbox/flexbox-align-self-baseline-horiz-008.xhtml from Interop 2023 #320

Closed
davidsgrogan opened this issue Apr 17, 2023 · 13 comments
Labels
focus area: Flexbox test-change-proposal Proposal to add or remove tests for an interop area

Comments

@davidsgrogan
Copy link
Member

Test List

https://wpt.fyi/results/css/css-flexbox/flexbox-align-self-baseline-horiz-008.xhtml?label=experimental&label=master&product=chrome&product=firefox&product=safari&aligned&view=subtest

Rationale

Relies on having implemented writing-mode: sideways-rl;, a feature that neither Webkit nor Blink have shipped, and isn't part of Interop 2023.

@davidsgrogan davidsgrogan added the test-change-proposal Proposal to add or remove tests for an interop area label Apr 17, 2023
@foolip
Copy link
Member

foolip commented Apr 26, 2023

@jgraham can you review this for Gecko?

@gsnedders @nt1m can you review this for WebKit?

@nt1m
Copy link
Member

nt1m commented Apr 26, 2023

Is it possible to replace with vertical-lr/rl? or is that already covered by another test?

But yeah, I agree we shouldn't have tests relying on sideways WM for Interop 2023

@davidsgrogan
Copy link
Member Author

That's kind of covered by http://wpt.live/css/css-flexbox/flexbox-align-self-baseline-horiz-006.xhtml . I say "kind of" because 006 is about orthogonal children, not where the whole container is in a vertical writing mode.

Other than that, there isn't a straight translation of flexbox-align-self-baseline-horiz-008.xhtml for vertical writing modes.

Switching to vertical writing mode SGTM.

@foolip
Copy link
Member

foolip commented Apr 27, 2023

@davidsgrogan is the conclusion to update this test instead of removing it?

@davidsgrogan
Copy link
Member Author

Sorry, I'm new to the process... does the process require input from all 3 engines before there can BE a conclusion? (Haven't heard from gecko yet.)

@bfgeek
Copy link

bfgeek commented Apr 27, 2023

This test should just be excluded rather than changing. The test is valuable for implementations which implement the sideways variant, and we shouldn't decrease their test coverage to make a number go up. :).

Ian

@davidsgrogan
Copy link
Member Author

+1 to Ian. The more I thought about it I agree that we shouldn't change the test... it is a totally valid test as is, it just covers an area we're not doing this year.

@davidsgrogan
Copy link
Member Author

davidsgrogan commented May 9, 2023

ping @nt1m and @jgraham

Good to remove the test from the suite instead of modifying it?

@nt1m
Copy link
Member

nt1m commented May 9, 2023

that seems fine too

@foolip
Copy link
Member

foolip commented May 9, 2023

I've prepared web-platform-tests/wpt-metadata#4156. @jgraham WDYT?

@jgraham
Copy link
Contributor

jgraham commented May 11, 2023

@emilio Does removing this test seem reasonable?

@emilio
Copy link

emilio commented May 12, 2023

Seems reasonable

@foolip
Copy link
Member

foolip commented May 12, 2023

Cool, we have enough support for this now, I'll land web-platform-tests/wpt-metadata#4156.

github-actions bot pushed a commit to web-platform-tests/wpt-metadata that referenced this issue May 12, 2023
@foolip foolip closed this as completed May 12, 2023
@foolip foolip removed the agenda+ label May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
focus area: Flexbox test-change-proposal Proposal to add or remove tests for an interop area
Projects
None yet
Development

No branches or pull requests

8 participants