Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unreviewed scope increase: <input pattern> supporting RegExp v #345

Closed
zcorpan opened this issue May 25, 2023 · 6 comments
Closed

Unreviewed scope increase: <input pattern> supporting RegExp v #345

zcorpan opened this issue May 25, 2023 · 6 comments
Labels
focus area: Forms test-change-proposal Proposal to add or remove tests for an interop area

Comments

@zcorpan
Copy link
Member

zcorpan commented May 25, 2023

Test List

https://wpt.fyi/results/html/semantics/forms/the-input-element/pattern_attribute.html?label=master&label=experimental&product=chrome&product=firefox&product=safari&aligned&view=interop&q=label%3Ainterop-2022-forms%20or%20label%3Ainterop-2023-forms

Rationale

RegExp v flag wasn't in scope for Interop 2023. The new subtests for whatwg/html#7908 added in web-platform-tests/wpt#38547 currently fail in Firefox and Safari.

  • <input pattern> supports set difference syntax
  • <input pattern> supports string literal syntax
  • <input pattern> enables the RegExp v flag

We could either remove this test file from Interop (since no other subtests fail), or split into two files, or mark the new tests with assert_implements_optional (maybe feature-checking support for the v flag on RegExp).

@zcorpan zcorpan added the test-change-proposal Proposal to add or remove tests for an interop area label May 25, 2023
@foolip
Copy link
Member

foolip commented May 25, 2023

cc @mathiasbynens. If it's easy to split these tests out, that would be the most expedient I think.

@zcorpan
Copy link
Member Author

zcorpan commented Jun 1, 2023

PR web-platform-tests/wpt#40343

@zcorpan
Copy link
Member Author

zcorpan commented Jun 2, 2023

@annevk wrote

I somewhat prefer excluding this instead, but I don't care too strongly.

Either way is ok for me. @foolip what say you?

@foolip
Copy link
Member

foolip commented Jun 5, 2023

I've asked @mathiasbynens and we have no strong opinion. I would go with whatever is easiest for everyone involved, and I think splitting like in web-platform-tests/wpt#40343 is easiest.

zcorpan added a commit to web-platform-tests/wpt that referenced this issue Jun 5, 2023
@zcorpan zcorpan closed this as completed Jun 5, 2023
@zcorpan
Copy link
Member Author

zcorpan commented Jun 5, 2023

@gsnedders @nt1m fyi

@nt1m
Copy link
Member

nt1m commented Jun 5, 2023

Seems fine to me either way, no strong opinion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
focus area: Forms test-change-proposal Proposal to add or remove tests for an interop area
Projects
None yet
Development

No branches or pull requests

3 participants