Skip to content

Commit

Permalink
[@container] Stop legacy propagation for CQ recalc container
Browse files Browse the repository at this point in the history
An element can be a container for size container queries even if size
containment does not apply, which meant the
IsContainerForContainerQueries check returns true for table type display
elements which meant we could end up with table layout trees which mixed
legacy and NG.

Instead check for the container being recalc'ed during layout
specifically to avoid detaching the layout boxes which had been laid
out.

Bug: 1291471, 1291109
Change-Id: I6f7a65e77a90a09c320d75da5e836d7f8be9b86b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3431427
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/main@{#966260}
  • Loading branch information
Rune Lillesveen authored and chromium-wpt-export-bot committed Feb 2, 2022
1 parent 197bef9 commit 0598a56
Showing 1 changed file with 10 additions and 0 deletions.
10 changes: 10 additions & 0 deletions css/css-contain/container-queries/columns-in-table-001-crash.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
<!doctype html>
<title>CSS Container Queries Test: TR container with multicol TD crashes Chrome</title>
<link rel="help" href="https://drafts.csswg.org/css-contain-3/#size-container">
<link rel="help" href="https://crbug.com/1291471">
<p>Pass if test does not crash.</p>
<table>
<tr style="container-type:size;">
<td style="columns:2"></td>
</tr>
</table>

0 comments on commit 0598a56

Please sign in to comment.