-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[@container] Change order of container shorthand
Adjust ConsumeContainerName so that we don't fail parsing completely whenever we encounter something unexpected. Since the initial value of container-type is an open issue [1], I'm leaving that as-is for now. Fixed: 1305128 [1] w3c/csswg-drafts#7202 Change-Id: I156a8da9a79d2108935958f3418b16aeb83d490e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3575938 Reviewed-by: Rune Lillesveen <futhark@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/main@{#990367}
- Loading branch information
1 parent
9e82f5e
commit 31bd027
Showing
6 changed files
with
43 additions
and
38 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
css/css-contain/container-queries/crashtests/chrome-bug-1289718-000-crash.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
<!DOCTYPE html> | ||
<link rel="author" title="Morten Stenshorne" href="mailto:mstensho@chromium.org"> | ||
<link rel="help" href="https://bugs.chromium.org/p/chromium/issues/detail?id=1289718"> | ||
<div style="container:inline-size;"> | ||
<div style="container-type:inline-size;"> | ||
<span style="columns:2;"></span> | ||
</div> |
2 changes: 1 addition & 1 deletion
2
css/css-contain/container-queries/crashtests/chrome-bug-1289718-001-crash.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
<!DOCTYPE html> | ||
<link rel="author" title="Morten Stenshorne" href="mailto:mstensho@chromium.org"> | ||
<link rel="help" href="https://bugs.chromium.org/p/chromium/issues/detail?id=1289718"> | ||
<div style="container:inline-size;"> | ||
<div style="container-type:inline-size;"> | ||
<video style="columns:2;"></video> | ||
</div> |