Skip to content

Commit

Permalink
Remove obsolete done calls
Browse files Browse the repository at this point in the history
  • Loading branch information
MattiasBuelens committed Nov 22, 2018
1 parent 50b2839 commit 45185ed
Show file tree
Hide file tree
Showing 59 changed files with 0 additions and 118 deletions.
2 changes: 0 additions & 2 deletions streams/byte-length-queuing-strategy.any.js
Original file line number Diff line number Diff line change
Expand Up @@ -107,5 +107,3 @@ test(() => {
'ByteLengthQueuingStrategy.name must be "ByteLengthQueuingStrategy"');

}, 'ByteLengthQueuingStrategy.name is correct');

done();
2 changes: 0 additions & 2 deletions streams/count-queuing-strategy.any.js
Original file line number Diff line number Diff line change
Expand Up @@ -106,5 +106,3 @@ test(() => {
'CountQueuingStrategy.name must be "CountQueuingStrategy"');

}, 'CountQueuingStrategy.name is correct');

done();
2 changes: 0 additions & 2 deletions streams/piping/abort.any.js
Original file line number Diff line number Diff line change
Expand Up @@ -358,5 +358,3 @@ promise_test(t => {
assert_array_equals(rs.events, ['pull'], 'cancel should not have been called');
});
}, 'abort should do nothing after the writable is errored');

done();
2 changes: 0 additions & 2 deletions streams/piping/close-propagation-backward.any.js
Original file line number Diff line number Diff line change
Expand Up @@ -151,5 +151,3 @@ promise_test(t => {

}, 'Closing must be propagated backward: starts closed; preventCancel = true, preventAbort = true, preventClose ' +
'= true');

done();
2 changes: 0 additions & 2 deletions streams/piping/close-propagation-forward.any.js
Original file line number Diff line number Diff line change
Expand Up @@ -587,5 +587,3 @@ promise_test(t => {
]);
});
}, 'Closing must be propagated forward: erroring the writable while flushing pending writes should error pipeTo');

done();
2 changes: 0 additions & 2 deletions streams/piping/error-propagation-backward.any.js
Original file line number Diff line number Diff line change
Expand Up @@ -628,5 +628,3 @@ promise_test(t => {
});

}, 'Errors must be propagated backward: erroring via the controller errors once pending write completes');

done();
2 changes: 0 additions & 2 deletions streams/piping/error-propagation-forward.any.js
Original file line number Diff line number Diff line change
Expand Up @@ -567,5 +567,3 @@ promise_test(t => {
});

}, 'Errors must be propagated forward: shutdown must not occur until the final write completes; becomes errored after first write; preventAbort = true');

done();
2 changes: 0 additions & 2 deletions streams/piping/flow-control.any.js
Original file line number Diff line number Diff line change
Expand Up @@ -299,5 +299,3 @@ promise_test(() => {
]);
});
}, 'Piping to a WritableStream that does not consume the writes fast enough exerts backpressure on the ReadableStream');

done();
2 changes: 0 additions & 2 deletions streams/piping/general.any.js
Original file line number Diff line number Diff line change
Expand Up @@ -188,5 +188,3 @@ for (const preventCancel of [true, false]) {

}, `an undefined rejection from write should cause pipeTo() to reject when preventCancel is ${preventCancel}`);
}

done();
2 changes: 0 additions & 2 deletions streams/piping/multiple-propagation.any.js
Original file line number Diff line number Diff line change
Expand Up @@ -225,5 +225,3 @@ promise_test(() => {
});

}, 'Piping from a closed readable stream to a closed writable stream');

done();
2 changes: 0 additions & 2 deletions streams/piping/pipe-through.any.js
Original file line number Diff line number Diff line change
Expand Up @@ -254,5 +254,3 @@ test(() => {
assert_equals(count, 1, 'pipeTo was called once');

}, 'pipeThrough should work with no options argument');

done();
2 changes: 0 additions & 2 deletions streams/piping/then-interception.any.js
Original file line number Diff line number Diff line change
Expand Up @@ -60,5 +60,3 @@ promise_test(async () => {
assert_array_equals(intercepted, [], 'nothing should have been intercepted');
assert_array_equals(ws.events, ['write', 'a', 'close'], 'written chunk should be "a"');
}, 'tee should not be observable');

done();
2 changes: 0 additions & 2 deletions streams/piping/transform-streams.any.js
Original file line number Diff line number Diff line change
Expand Up @@ -20,5 +20,3 @@ promise_test(() => {
return writer.closed;
});
}, 'Piping through an identity transform stream should close the destination when the source closes');

done();
2 changes: 0 additions & 2 deletions streams/readable-byte-streams/brand-checks.any.js
Original file line number Diff line number Diff line change
Expand Up @@ -187,5 +187,3 @@ promise_test(t => {
}

}, 'ReadableStreamBYOBRequest enforces brand checks');

done();
2 changes: 0 additions & 2 deletions streams/readable-byte-streams/constructor.any.js
Original file line number Diff line number Diff line change
Expand Up @@ -46,5 +46,3 @@ for (const failureOp of operations) {
'operations should be performed in the right order');
}, `ReadableStream constructor should stop after ${failureOp} fails`);
}

done();
2 changes: 0 additions & 2 deletions streams/readable-byte-streams/detached-buffers.any.js
Original file line number Diff line number Diff line change
Expand Up @@ -149,5 +149,3 @@ async_test(t => {
reader.read(new Uint8Array([4, 5, 6]));
}, 'ReadableStream with byte source: respondWithNewView() throws if the supplied view\'s buffer has been detached ' +
'(in the closed state)');

done();
2 changes: 0 additions & 2 deletions streams/readable-byte-streams/general.any.js
Original file line number Diff line number Diff line change
Expand Up @@ -2119,5 +2119,3 @@ test(() => {
assert_throws(new RangeError(), () => new ReadableStream({ type: 'bytes' }, new HasSizeMethod()),
'constructor should throw when size on the prototype chain');
}, 'ReadableStream constructor should not accept a strategy with a size defined if type is "bytes"');

done();
2 changes: 0 additions & 2 deletions streams/readable-byte-streams/properties.any.js
Original file line number Diff line number Diff line change
Expand Up @@ -140,5 +140,3 @@ test(() => {
assert_equals(controller.error.length, 1, 'releaseLock has 1 parameter');

}, 'ReadableByteStreamController instances should have the correct list of properties');

done();
2 changes: 0 additions & 2 deletions streams/readable-streams/bad-strategies.any.js
Original file line number Diff line number Diff line change
Expand Up @@ -157,5 +157,3 @@ promise_test(() => {
return Promise.all(promises);

}, 'Readable stream: invalid strategy.size return value');

done();
2 changes: 0 additions & 2 deletions streams/readable-streams/bad-underlying-sources.any.js
Original file line number Diff line number Diff line change
Expand Up @@ -398,5 +398,3 @@ promise_test(t => {
});

}, 'read should not error if it dequeues and pull() throws');

done();
2 changes: 0 additions & 2 deletions streams/readable-streams/brand-checks.any.js
Original file line number Diff line number Diff line change
Expand Up @@ -157,5 +157,3 @@ test(() => {
[fakeRSDefaultController(), realRS(), realRSDefaultReader(), undefined, null]);

}, 'ReadableStreamDefaultController.prototype.error enforces a brand check');

done();
2 changes: 0 additions & 2 deletions streams/readable-streams/cancel.any.js
Original file line number Diff line number Diff line change
Expand Up @@ -234,5 +234,3 @@ promise_test(() => {
return Promise.all([rs.cancel(), rs.getReader().closed]);

}, 'ReadableStream cancellation: cancelling before start finishes should prevent pull() from being called');

done();
2 changes: 0 additions & 2 deletions streams/readable-streams/constructor.any.js
Original file line number Diff line number Diff line change
Expand Up @@ -35,5 +35,3 @@ for (const failureOp of operations) {
'operations should be performed in the right order');
}, `ReadableStream constructor should stop after ${failureOp} fails`);
}

done();
Original file line number Diff line number Diff line change
Expand Up @@ -206,5 +206,3 @@ promise_test(() => {
});

}, 'Correctly governs a ReadableStreamController\'s desiredSize property (HWM = 4)');

done();
2 changes: 0 additions & 2 deletions streams/readable-streams/default-reader.any.js
Original file line number Diff line number Diff line change
Expand Up @@ -494,5 +494,3 @@ test(() => {
assert_throws(new RangeError(), () => rs.getReader({ mode }), 'getReader() should throw');
assert_true(toStringCalled, 'toString() should be called');
}, 'getReader() should call ToString() on mode');

done();
Original file line number Diff line number Diff line change
Expand Up @@ -114,5 +114,3 @@ function setupTestStream() {

return { reader: rs.getReader(), controller };
}

done();
2 changes: 0 additions & 2 deletions streams/readable-streams/garbage-collection.any.js
Original file line number Diff line number Diff line change
Expand Up @@ -68,5 +68,3 @@ promise_test(() => {
'old reader should still be locking the stream even after garbage collection'));

}, 'Garbage-collecting a ReadableStreamDefaultReader should not unlock its stream');

done();
2 changes: 0 additions & 2 deletions streams/readable-streams/general.any.js
Original file line number Diff line number Diff line change
Expand Up @@ -894,5 +894,3 @@ promise_test(() => {
});

}, 'ReadableStream integration test: adapting an async pull source');

done();
2 changes: 0 additions & 2 deletions streams/readable-streams/patched-global.any.js
Original file line number Diff line number Diff line change
Expand Up @@ -57,5 +57,3 @@ test(t => {
assert_true(isReadableStream(branch1), 'branch1 should be a ReadableStream');
assert_true(isReadableStream(branch2), 'branch2 should be a ReadableStream');
}, 'ReadableStream tee() should not call the global ReadableStream');

done();
2 changes: 0 additions & 2 deletions streams/readable-streams/reentrant-strategies.any.js
Original file line number Diff line number Diff line change
Expand Up @@ -262,5 +262,3 @@ promise_test(() => {
readableStreamToArray(branch2).then(array => assert_array_equals(array, ['a'], 'branch2 should have one chunk'))
]);
}, 'tee() inside size() should work');

done();
2 changes: 0 additions & 2 deletions streams/readable-streams/tee.any.js
Original file line number Diff line number Diff line change
Expand Up @@ -286,5 +286,3 @@ test(t => {
assert_not_equals(getReader.call(rs2), undefined, 'getReader should work on rs2');

}, 'ReadableStreamTee should not use a modified ReadableStream constructor from the global object');

done();
2 changes: 0 additions & 2 deletions streams/readable-streams/templated.any.js
Original file line number Diff line number Diff line change
Expand Up @@ -141,5 +141,3 @@ templatedRSTwoChunksClosedReader('ReadableStream (two chunks enqueued, then clos
function streamAndDefaultReader(stream) {
return { stream, reader: stream.getReader() };
}

done();
2 changes: 0 additions & 2 deletions streams/transform-streams/backpressure.any.js
Original file line number Diff line number Diff line change
Expand Up @@ -193,5 +193,3 @@ promise_test(t => {
return promise_rejects(t, error1, pipePromise, 'promise returned from pipeTo() should be rejected');
});
}, 'cancelling the readable side of a TransformStream should abort a full pipe');

done();
2 changes: 0 additions & 2 deletions streams/transform-streams/brand-checks.any.js
Original file line number Diff line number Diff line change
Expand Up @@ -72,5 +72,3 @@ test(() => {
methodThrowsForAll(TransformStreamDefaultController.prototype, 'error',
[fakeTSDefaultController(), realTS(), undefined, null]);
}, 'TransformStreamDefaultController.prototype.error enforces a brand check');

done();
2 changes: 0 additions & 2 deletions streams/transform-streams/constructor.any.js
Original file line number Diff line number Diff line change
Expand Up @@ -44,5 +44,3 @@ for (const failureOp of operations) {
'operations should be performed in the right order');
}, `TransformStream constructor should stop after ${failureOp} fails`);
}

done();
2 changes: 0 additions & 2 deletions streams/transform-streams/errors.any.js
Original file line number Diff line number Diff line change
Expand Up @@ -339,5 +339,3 @@ promise_test(t => {
const reader = ts.readable.getReader();
return promise_rejects(t, thrownError, reader.read(), 'read() should reject with thrownError');
}, 'the readable should be errored with the reason passed to the writable abort() method');

done();
2 changes: 0 additions & 2 deletions streams/transform-streams/flush.any.js
Original file line number Diff line number Diff line change
Expand Up @@ -129,5 +129,3 @@ promise_test(t => {
});
return promise_rejects(t, error1, ts.writable.getWriter().close(), 'close() should reject');
}, 'error() during flush should cause writer.close() to reject');

done();
2 changes: 0 additions & 2 deletions streams/transform-streams/general.any.js
Original file line number Diff line number Diff line change
Expand Up @@ -437,5 +437,3 @@ test(() => {
test(() => {
assert_throws(new RangeError(), () => new TransformStream({ writableType: 'bytes' }), 'constructor should throw');
}, 'specifying a defined writableType should throw');

done();
2 changes: 0 additions & 2 deletions streams/transform-streams/lipfuzz.any.js
Original file line number Diff line number Diff line change
Expand Up @@ -161,5 +161,3 @@ for (const testCase of cases) {
return Promise.all(promises);
}, `testing "${inputChunks}" (length ${inputChunks.length})`);
}

done();
2 changes: 0 additions & 2 deletions streams/transform-streams/patched-global.any.js
Original file line number Diff line number Diff line change
Expand Up @@ -43,5 +43,3 @@ test(t => {
assert_not_equals(getWriter.call(ts.writable), undefined,
'getWriter should work when called on ts.writable');
}, 'TransformStream should use the original value of ReadableStream and WritableStream');

done();
2 changes: 0 additions & 2 deletions streams/transform-streams/properties.any.js
Original file line number Diff line number Diff line change
Expand Up @@ -187,5 +187,3 @@ for (const method in transformerMethods) {
});
}, `unexpected properties should not be accessed when calling transformer method ${method}`);
}

done();
2 changes: 0 additions & 2 deletions streams/transform-streams/reentrant-strategies.any.js
Original file line number Diff line number Diff line change
Expand Up @@ -317,5 +317,3 @@ promise_test(t => {
return Promise.all([promise_rejects(t, error1, reader.read(), 'read() should reject'), abortPromise]);
});
}, 'writer.abort() inside size() should work');

done();
2 changes: 0 additions & 2 deletions streams/transform-streams/strategies.any.js
Original file line number Diff line number Diff line change
Expand Up @@ -148,5 +148,3 @@ promise_test(t => {
});
}, 'a bad readableStrategy size function should error the stream on enqueue even when transformer.transform() ' +
'catches the exception');

done();
2 changes: 0 additions & 2 deletions streams/transform-streams/terminate.any.js
Original file line number Diff line number Diff line change
Expand Up @@ -98,5 +98,3 @@ promise_test(() => {
ts.readable.getReader().closed
]);
}, 'controller.terminate() inside flush() should not prevent writer.close() from succeeding');

done();
2 changes: 0 additions & 2 deletions streams/writable-streams/aborting.any.js
Original file line number Diff line number Diff line change
Expand Up @@ -1368,5 +1368,3 @@ promise_test(t => {
e => assert_equals(e, 'string argument', 'e should be \'string argument\''));
});
}, 'abort with a string argument should set the stored error to that argument');

done();
2 changes: 0 additions & 2 deletions streams/writable-streams/bad-strategies.any.js
Original file line number Diff line number Diff line change
Expand Up @@ -93,5 +93,3 @@ test(() => {
highWaterMark: NaN
}), 'WritableStream constructor should throw a TypeError');
}, 'Writable stream: invalid size beats invalid highWaterMark');

done();
2 changes: 0 additions & 2 deletions streams/writable-streams/bad-underlying-sinks.any.js
Original file line number Diff line number Diff line change
Expand Up @@ -188,5 +188,3 @@ promise_test(t => {
return promise_rejects(t, error1, writer.abort(abortReason), 'abort should reject with the thrown error')
.then(() => promise_rejects(t, abortReason, writer.closed, 'closed should reject with abortReason'));
}, 'abort: throwing method should cause abort() and closed to reject');

done();
2 changes: 0 additions & 2 deletions streams/writable-streams/brand-checks.any.js
Original file line number Diff line number Diff line change
Expand Up @@ -107,5 +107,3 @@ test(() => {
methodThrowsForAll(WritableStreamDefaultController.prototype, 'error',
[fakeWSDefaultController(), realWS(), realWSDefaultWriter(), undefined, null]);
}, 'WritableStreamDefaultController.prototype.error enforces a brand check');

done();
2 changes: 0 additions & 2 deletions streams/writable-streams/byte-length-queuing-strategy.any.js
Original file line number Diff line number Diff line change
Expand Up @@ -26,5 +26,3 @@ promise_test(t => {

return writer.close();
}, 'Closing a writable stream with in-flight writes below the high water mark delays the close call properly');

done();
2 changes: 0 additions & 2 deletions streams/writable-streams/close.any.js
Original file line number Diff line number Diff line change
Expand Up @@ -399,5 +399,3 @@ promise_test(t => {
});
});
}, 'close() should not reject until no sink methods are in flight');

done();
2 changes: 0 additions & 2 deletions streams/writable-streams/constructor.any.js
Original file line number Diff line number Diff line change
Expand Up @@ -183,5 +183,3 @@ for (const failureOp of operations) {
'operations should be performed in the right order');
}, `WritableStream constructor should stop after ${failureOp} fails`);
}

done();
2 changes: 0 additions & 2 deletions streams/writable-streams/count-queuing-strategy.any.js
Original file line number Diff line number Diff line change
Expand Up @@ -122,5 +122,3 @@ promise_test(() => {
assert_equals(writer.desiredSize, -1, 'desiredSize should be -1 after 9th write()');
});
}, 'Correctly governs the value of a WritableStream\'s state property (HWM = 4)');

done();
2 changes: 0 additions & 2 deletions streams/writable-streams/error.any.js
Original file line number Diff line number Diff line change
Expand Up @@ -62,5 +62,3 @@ promise_test(() => {
controller.error(error1);
});
}, 'controller.error() on closed stream should not throw');

done();
Original file line number Diff line number Diff line change
Expand Up @@ -85,5 +85,3 @@ function setupTestStream() {

return ws.getWriter();
}

done();
2 changes: 0 additions & 2 deletions streams/writable-streams/general.any.js
Original file line number Diff line number Diff line change
Expand Up @@ -244,5 +244,3 @@ promise_test(() => {
});
});
}, 'ready promise should fire before closed on releaseLock');

done();
2 changes: 0 additions & 2 deletions streams/writable-streams/properties.any.js
Original file line number Diff line number Diff line change
Expand Up @@ -218,5 +218,3 @@ for (const method in sinkMethods) {
});
}, `unexpected properties should not be accessed when calling sink method ${method}`);
}

done();
2 changes: 0 additions & 2 deletions streams/writable-streams/reentrant-strategy.any.js
Original file line number Diff line number Diff line change
Expand Up @@ -172,5 +172,3 @@ promise_test(t => {
assert_array_equals(ws.events, ['write', 0, 'close'], 'sink.write() should only be called once');
});
}, 'original reader should error when new reader is created within strategy.size()');

done();
2 changes: 0 additions & 2 deletions streams/writable-streams/start.any.js
Original file line number Diff line number Diff line change
Expand Up @@ -161,5 +161,3 @@ promise_test(t => {
assert_array_equals(events, ['ready', 'write', 'closed'], 'promises should reject in standard order');
});
}, 'when start() rejects, writer promises should reject in standard order');

done();
2 changes: 0 additions & 2 deletions streams/writable-streams/write.any.js
Original file line number Diff line number Diff line change
Expand Up @@ -251,5 +251,3 @@ promise_test(() => {
});
return ws.getWriter().write('a').then(() => assert_true(thenCalled, 'thenCalled should be true'));
}, 'returning a thenable from write() should work');

done();

0 comments on commit 45185ed

Please sign in to comment.