Skip to content

Commit

Permalink
Flip a couple pass conditions
Browse files Browse the repository at this point in the history
  • Loading branch information
domenic committed Apr 15, 2021
1 parent 1e1412e commit 475d000
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 20 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,6 @@
assert_equals(history.length, startingHistoryLength, "Inserting the under-test iframe must not change history.length");

await waitForLoadAllowingIntermediateLoads(t, iframe, afterReplacementURL);
assert_equals(history.length, startingHistoryLength, "history.length must not change after waiting for the replacement");

await checkSentinelIframe(t, sentinelIframe);
assert_equals(history.length, startingHistoryLength, "history.length must not change after checking the sentinel iframe");
}, "Replace during the load event, triggered by aElement.click()");
assert_equals(history.length, startingHistoryLength + 1, "history.length must change after waiting for the load");
}, "aElement.click() during the load event must NOT replace");
</script>
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,6 @@
assert_equals(history.length, startingHistoryLength, "Inserting the under-test iframe must not change history.length");

await waitForLoad(t, iframe, afterReplacementURL);
assert_equals(history.length, startingHistoryLength, "history.length must not change after waiting for the replacement");

await checkSentinelIframe(t, sentinelIframe);
assert_equals(history.length, startingHistoryLength, "history.length must not change after checking the sentinel iframe");
}, "Replace before load, triggered by aElement.click()");
assert_equals(history.length, startingHistoryLength + 1, "history.length must change after waiting for the load");
}, "aElement.click() before the load event must NOT replace");
</script>
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,6 @@
assert_equals(history.length, startingHistoryLength, "Inserting the under-test iframe must not change history.length");

await waitForLoadAllowingIntermediateLoads(t, iframe, afterReplacementURL);
assert_equals(history.length, startingHistoryLength, "history.length must not change after waiting for the replacement");

await checkSentinelIframe(t, sentinelIframe);
assert_equals(history.length, startingHistoryLength, "history.length must not change after checking the sentinel iframe");
}, "Replace during the load event, triggered by history.pushState()");
assert_equals(history.length, startingHistoryLength + 1, "history.length must change after waiting for the replacement");
}, "history.pushState() during the load event must NOT replace");
</script>
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,6 @@
assert_equals(history.length, startingHistoryLength, "Inserting the under-test iframe must not change history.length");

await waitForLoad(t, iframe, afterReplacementURL);
assert_equals(history.length, startingHistoryLength, "history.length must not change after waiting for the replacement");

await checkSentinelIframe(t, sentinelIframe);
assert_equals(history.length, startingHistoryLength, "history.length must not change after checking the sentinel iframe");
}, "Replace before load, triggered by history.pushState()");
assert_equals(history.length, startingHistoryLength + 1, "history.length must change after waiting for the replacement");
}, "history.pushState() before the load event must NOT replace");
</script>

0 comments on commit 475d000

Please sign in to comment.