Skip to content

Commit

Permalink
Fix crash detection for testharness tests with servo executor
Browse files Browse the repository at this point in the history
  • Loading branch information
jgraham committed Jun 10, 2015
1 parent 27ae6ed commit 903989e
Showing 1 changed file with 10 additions and 7 deletions.
17 changes: 10 additions & 7 deletions wptrunner/executors/executorservo.py
Original file line number Diff line number Diff line change
Expand Up @@ -99,15 +99,18 @@ def do_test(self, test):
self.proc.wait()

proc_is_running = True
if self.result_flag.is_set() and self.result_data is not None:
self.result_data["test"] = test.url
result = self.convert_result(test, self.result_data)
else:
if self.proc.poll() is not None:

if self.result_flag.is_set():
if self.result_data is not None:
self.result_data["test"] = test.url
result = self.convert_result(test, self.result_data)
else:
self.proc.wait()
result = (test.result_cls("CRASH", None), [])
proc_is_running = False
else:
result = (test.result_cls("TIMEOUT", None), [])
else:
result = (test.result_cls("TIMEOUT", None), [])


if proc_is_running:
if self.pause_after_test:
Expand Down

0 comments on commit 903989e

Please sign in to comment.