Skip to content

Commit

Permalink
[FlexNG] MinBlockSizeShouldEncompassIntrinsicSize for flex rows
Browse files Browse the repository at this point in the history
Update the MinBlockSizeShouldEncompassIntrinsicSize() calculation for
flex row items to check if the container has an auto block-size
in addition to whether or not the cross-size of the item would be
the container size. Otherwise, we would fail to correctly expand
due to fragmentation in some cases.

See CL:3600998 for where the original logic was added.

Bug: 1409030
Change-Id: I45b5455f16c84e0d409ebbfa3bf1b0994aff2feb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4193452
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Alison Maher <almaher@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1097496}
  • Loading branch information
alisonmaher authored and chromium-wpt-export-bot committed Jan 26, 2023
1 parent 1f2389b commit c1061a6
Showing 1 changed file with 16 additions and 0 deletions.
16 changes: 16 additions & 0 deletions css/css-break/flexbox/nested-flex-item-expansion-in-mulicol.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
<!DOCTYPE html>
<link rel="help" href="https://drafts.csswg.org/css-flexbox-1/#pagination">
<link rel="match" href="../../reference/ref-filled-green-100px-square.xht">
<p>Test passes if there is a filled green square and <strong>no red</strong>.</p>
<div style="columns:2; gap:0; column-fill:auto; width:100px; height:100px; background:red;">
<div style="height:50px; background:green;"></div>
<div style="display:flex;">
<div style="display:flex;">
<div style="width:50px;">
<div style="height:30px;"></div>
<div style="height:50px; contain:size; background:green;"></div>
</div>
</div>
</div>
<div style="height:50px; margin-left:-100%; width:200%; background:green;"></div>
</div>

0 comments on commit c1061a6

Please sign in to comment.