-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regressions from "Make testharness tests run in a top-level browsing context" #14495
Comments
It seems like in some cases it may have helped though, e.g. https://wpt.fyi/results/keyboard-lock?label=experimental&product=chrome%5Btaskcluster%5D%405dd605cdfa&product=chrome%5Btaskcluster%5D%40c522b884f7&diff . This indicates many other tests may have been suffering from the same problems as the ones that prompted the original issue. |
I think I would have preferred not to revert this since it looks like it's probably a net win. However issues for regressions should certainly be top priority (I'm looking at the PiP tests now but I'm not sure what's going wrong). |
…top-level browsing context", a=testonly Automatic update from web-platform-tests Revert "Make testharness tests run in a top-level browsing context" (#14496) This reverts commit 74522a275bea481821e789145578e9e16fd27be3. Fixes web-platform-tests/wpt#14495. Reopens web-platform-tests/wpt#13418. -- wpt-commits: 9377b490049c9af88ea0261ad3b92757733e8e95 wpt-pr: 14496 --HG-- rename : testing/web-platform/tests/tools/wptrunner/wptrunner/browsers/base.py => testing/web-platform/tests/tools/wptrunner/wptrunner/browsers/base.py.orig rename : testing/web-platform/tests/tools/wptrunner/wptrunner/browsers/sauce.py => testing/web-platform/tests/tools/wptrunner/wptrunner/browsers/sauce.py.orig
…top-level browsing context", a=testonly Automatic update from web-platform-tests Revert "Make testharness tests run in a top-level browsing context" (#14496) This reverts commit 74522a275bea481821e789145578e9e16fd27be3. Fixes web-platform-tests/wpt#14495. Reopens web-platform-tests/wpt#13418. -- wpt-commits: 9377b490049c9af88ea0261ad3b92757733e8e95 wpt-pr: 14496
…top-level browsing context", a=testonly Automatic update from web-platform-tests Revert "Make testharness tests run in a top-level browsing context" (#14496) This reverts commit 74522a275bea481821e789145578e9e16fd27be3. Fixes web-platform-tests/wpt#14495. Reopens web-platform-tests/wpt#13418. -- wpt-commits: 9377b490049c9af88ea0261ad3b92757733e8e95 wpt-pr: 14496 UltraBlame original commit: 0f0edff319bf9938e6ce47e62c586d2f25919263
…top-level browsing context", a=testonly Automatic update from web-platform-tests Revert "Make testharness tests run in a top-level browsing context" (#14496) This reverts commit 74522a275bea481821e789145578e9e16fd27be3. Fixes web-platform-tests/wpt#14495. Reopens web-platform-tests/wpt#13418. -- wpt-commits: 9377b490049c9af88ea0261ad3b92757733e8e95 wpt-pr: 14496 UltraBlame original commit: 0f0edff319bf9938e6ce47e62c586d2f25919263
…top-level browsing context", a=testonly Automatic update from web-platform-tests Revert "Make testharness tests run in a top-level browsing context" (#14496) This reverts commit 74522a275bea481821e789145578e9e16fd27be3. Fixes web-platform-tests/wpt#14495. Reopens web-platform-tests/wpt#13418. -- wpt-commits: 9377b490049c9af88ea0261ad3b92757733e8e95 wpt-pr: 14496 UltraBlame original commit: 0f0edff319bf9938e6ce47e62c586d2f25919263
#13966 caused regressions in many tests, and @beaufortfrancois reported regressions in https://wpt.fyi/results/picture-in-picture?label=experimental.
Exact diff for Chome+Firefox experimental:
Diff spanning the change and more for Safari experimental:
https://wpt.fyi/results/?label=experimental&product=safari%5Bexperimental%5D%40e4a221e6c4&product=safari%5Bexperimental%5D%4048d5d5033d&diff
The text was updated successfully, but these errors were encountered: