Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regressions from "Make testharness tests run in a top-level browsing context" #14495

Closed
foolip opened this issue Dec 13, 2018 · 2 comments
Closed

Comments

@domenic
Copy link
Member

domenic commented Dec 13, 2018

It seems like in some cases it may have helped though, e.g. https://wpt.fyi/results/keyboard-lock?label=experimental&product=chrome%5Btaskcluster%5D%405dd605cdfa&product=chrome%5Btaskcluster%5D%40c522b884f7&diff . This indicates many other tests may have been suffering from the same problems as the ones that prompted the original issue.

@jgraham
Copy link
Contributor

jgraham commented Dec 13, 2018

I think I would have preferred not to revert this since it looks like it's probably a net win. However issues for regressions should certainly be top priority (I'm looking at the PiP tests now but I'm not sure what's going wrong).

moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Jan 23, 2019
…top-level browsing context", a=testonly

Automatic update from web-platform-tests
Revert "Make testharness tests run in a top-level browsing context" (#14496)

This reverts commit 74522a275bea481821e789145578e9e16fd27be3.

Fixes web-platform-tests/wpt#14495.

Reopens web-platform-tests/wpt#13418.
--

wpt-commits: 9377b490049c9af88ea0261ad3b92757733e8e95
wpt-pr: 14496


--HG--
rename : testing/web-platform/tests/tools/wptrunner/wptrunner/browsers/base.py => testing/web-platform/tests/tools/wptrunner/wptrunner/browsers/base.py.orig
rename : testing/web-platform/tests/tools/wptrunner/wptrunner/browsers/sauce.py => testing/web-platform/tests/tools/wptrunner/wptrunner/browsers/sauce.py.orig
mykmelez pushed a commit to mykmelez/gecko that referenced this issue Jan 23, 2019
…top-level browsing context", a=testonly

Automatic update from web-platform-tests
Revert "Make testharness tests run in a top-level browsing context" (#14496)

This reverts commit 74522a275bea481821e789145578e9e16fd27be3.

Fixes web-platform-tests/wpt#14495.

Reopens web-platform-tests/wpt#13418.
--

wpt-commits: 9377b490049c9af88ea0261ad3b92757733e8e95
wpt-pr: 14496
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this issue Oct 3, 2019
…top-level browsing context", a=testonly

Automatic update from web-platform-tests
Revert "Make testharness tests run in a top-level browsing context" (#14496)

This reverts commit 74522a275bea481821e789145578e9e16fd27be3.

Fixes web-platform-tests/wpt#14495.

Reopens web-platform-tests/wpt#13418.
--

wpt-commits: 9377b490049c9af88ea0261ad3b92757733e8e95
wpt-pr: 14496

UltraBlame original commit: 0f0edff319bf9938e6ce47e62c586d2f25919263
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this issue Oct 3, 2019
…top-level browsing context", a=testonly

Automatic update from web-platform-tests
Revert "Make testharness tests run in a top-level browsing context" (#14496)

This reverts commit 74522a275bea481821e789145578e9e16fd27be3.

Fixes web-platform-tests/wpt#14495.

Reopens web-platform-tests/wpt#13418.
--

wpt-commits: 9377b490049c9af88ea0261ad3b92757733e8e95
wpt-pr: 14496

UltraBlame original commit: 0f0edff319bf9938e6ce47e62c586d2f25919263
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this issue Oct 3, 2019
…top-level browsing context", a=testonly

Automatic update from web-platform-tests
Revert "Make testharness tests run in a top-level browsing context" (#14496)

This reverts commit 74522a275bea481821e789145578e9e16fd27be3.

Fixes web-platform-tests/wpt#14495.

Reopens web-platform-tests/wpt#13418.
--

wpt-commits: 9377b490049c9af88ea0261ad3b92757733e8e95
wpt-pr: 14496

UltraBlame original commit: 0f0edff319bf9938e6ce47e62c586d2f25919263
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants