Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a test confirming "Request body streams that cannot be retried" #28568

Open
yoichio opened this issue Apr 19, 2021 · 1 comment
Open

Add a test confirming "Request body streams that cannot be retried" #28568

yoichio opened this issue Apr 19, 2021 · 1 comment
Labels
fetch

Comments

@yoichio
Copy link
Contributor

yoichio commented Apr 19, 2021

From whatwg/fetch#538 (comment),

In particular, for request streams (i.e., streams API is being used) we allow a 64 kibibyte buffer for replays in the networking stack. Once that buffer is exceeded, the only recourse to having to resend is to terminate with a network error.

We should add a such test in fetch/api/basic/request-upload.any.js.
@yoichio yoichio mentioned this issue Apr 19, 2021
Merged
3 tasks
@annevk annevk added the fetch label Apr 19, 2021
@annevk
Copy link
Member

annevk commented Apr 19, 2021

Not stated in OP, but this is actually tricky to test in web-platform-tests as there's no reliable way to force a browser to resend (afaik).

annevk pushed a commit to whatwg/fetch that referenced this issue Apr 20, 2021
@yoichio
Add a limited size buffer for streaming upload in HTTP request
6453947 
No testing possible, tracked in web-platform-tests/wpt#28568.

Fixes #538.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
fetch
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@annevk @yoichio