user activation must survive postMessage() to call show() #10090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check that we can call pr.show() in an iframe via postMessage(), which is triggered by user activation.
wpt-pr-bot
requested review from
domenic,
mnoorenberghe,
MSFTkihans and
rsolomakhin
|
This passes in Chrome, but fails in Firefox ATM. |
Build PASSEDStarted: 2018-03-19 06:06:14 View more information about this build on: |
|
May help make progress on whatwg/html#1903 ? |
mnoorenberghe
approved these changes
Mar 21, 2018
|
On second thought… I think this is testing more than what's in the spec (correct me if I'm wrong) so I'm not sure the test is appropriate for now. |
|
@domenic wrote the spec text in HTML, so he can confirm :) |
|
Sorry, I'm on vacation until April :) |
Np! Enjoy! 🏖⛰🏙 |
vinicius0197
pushed a commit
to vinicius0197/web-platform-tests
that referenced
this pull request
Mar 23, 2018
…rm-tests#10090) Check that we can call pr.show() in an iframe via postMessage(), which is triggered by user activation.
vinicius0197
pushed a commit
to vinicius0197/web-platform-tests
that referenced
this pull request
Mar 23, 2018
…rm-tests#10090) Check that we can call pr.show() in an iframe via postMessage(), which is triggered by user activation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check that we can call pr.show() in an iframe via postMessage(), which
is triggered by user activation.