Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct importScripts() behavior test #11315

Merged
merged 1 commit into from
Jun 3, 2018
Merged

Correct importScripts() behavior test #11315

merged 1 commit into from
Jun 3, 2018

Conversation

jungkees
Copy link
Contributor

@jungkees jungkees commented Jun 2, 2018

  • Update the after-install call to expect NetworkError instead of TypeError.
  • Initialize echo_output before calling importScripts().

@jungkees
Correct importScripts() behavior test
15951e2 
- Update the after-install call to expect NetworkError instead of TypeError.
- Initialize echo_output before calling importScripts().
@jungkees jungkees mentioned this pull request Jun 2, 2018
Closed
wanderview
wanderview approved these changes Jun 3, 2018
View reviewed changes
Copy link
Member

@wanderview wanderview left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Identical to what I came up with, but I didn't need the echo_output = null in test_import(). Do you really need that?

@jungkees
Copy link
Contributor Author

jungkees commented Jun 3, 2018

Not for this particular case and status but for error prevention puppose for future changes.

@jungkees jungkees merged commit ee82278 into master Jun 3, 2018
@jungkees jungkees deleted the importscripts-fix branch June 3, 2018 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wanderview wanderview wanderview approved these changes

@cdumez cdumez Awaiting requested review from cdumez

@mfalken mfalken Awaiting requested review from mfalken

@aliams aliams Awaiting requested review from aliams

@asutherland asutherland Awaiting requested review from asutherland

@beidson beidson Awaiting requested review from beidson

@mkruisselbrink mkruisselbrink Awaiting requested review from mkruisselbrink

Assignees
No one assigned
Labels
service-workers wg-sw
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jungkees @wanderview @wpt-pr-bot