Add WPT for :scope selector on shadow trees #12252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Aug 1, 2018
chromium-wpt-export-bot
changed the title
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1158445
branch
3 times, most recently
from
d16b3d0
to
e3b3c8b
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1158445
branch
5 times, most recently
from
6ed9771
to
85ff5dd
Compare
This WPT shows that :scope does not work for shadow root. :scope matches nothing when the direct child element or descendant of shadow root should be selected, while :scope works fine for descendant elements within shadow root. Link to the spec: https://drafts.csswg.org/selectors-4/#the-scope-pseudo Link to related issue: w3c/csswg-drafts#3016 Bug: 859692 Change-Id: I801706eb7891035dcb900588d5542bd48fa1c12a Reviewed-on: https://chromium-review.googlesource.com/1158445 Commit-Queue: Momoko Sumida <momon@google.com> Reviewed-by: Rakina Zata Amni <rakina@chromium.org> Reviewed-by: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#583210}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1158445
branch
from
85ff5dd
to
4ff4c11
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This WPT shows that :scope does not work for shadow root.
:scope matches nothing when the direct child element or descendant of shadow root should be selected, while :scope works fine for descendant elements within shadow root.
Link to the spec:
https://drafts.csswg.org/selectors-4/#the-scope-pseudo
Link to related issue:
w3c/csswg-drafts#3016
Bug: 859692
Change-Id: I801706eb7891035dcb900588d5542bd48fa1c12a
Reviewed-on: https://chromium-review.googlesource.com/1158445
Commit-Queue: Momoko Sumida momon@google.com
Reviewed-by: Rakina Zata Amni rakina@chromium.org
Reviewed-by: Hayato Ito hayato@chromium.org
Cr-Commit-Position: refs/heads/master@{#583210}