html,custom-elements: Add tests for HTMLElement.attachInternals() #15123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
requested review from
domenic,
foolip,
hayatoito,
kojiishi,
lukebjerring,
rniwa,
snuggs and
TakayoshiKochi
|
The taskcluster failure is for unstable css/css-font-loading/idlharness.https.html. This PR is unrelated to it. |
|
Tests look OK. Do you have a PR for the change to the spec? Typically the new IDL method definition will automatically be picked up by the reffy-reports scraper at a later date when that change lands, but it's fine to manually attach the same IDL change to this PR in the meantime - the only concern is that the pipeline may attempt to revert the change if it has not landed. |
domenic
approved these changes
Jan 30, 2019
| assert_true(span instanceof HTMLElement); | ||
| assert_throws('InvalidStateError', () => { span.attachInternals(); }); | ||
|
|
||
| const undefinedCustom = document.createElement('my-element'); |
There was a problem hiding this comment.
This may be a bit clearer if you use undefined-element instead of my-element. Right now I had to look up to see what names you had defined so far and see that only my-element1 was defined, not my-element.
|
Because html.idl was modified, Taskcluster ran all tests that depend on html.idl. That ran into #14862. The Firefox logs are too get to the end to find the problem :/ |
|
I've tried to fix one of the problems in #15170 if anyone would care to review. |
|
Filed #15171, but also was finally able to find the cause: Unstable results
That's #14254. In any event, it's OK to merge with the Taskcluster failures on this PR, just ask an admin, like me or @jgraham. |
chromium-wpt-export-bot
pushed a commit
that referenced
this pull request
Feb 22, 2019
…res'. This change is for whatwg/html#4324, and a follow-up of #15123 Bug: crbug.com/905922 Change-Id: I3eceb5d21ab555c23ed877ded17d359fe004e2aa
chromium-wpt-export-bot
pushed a commit
that referenced
this pull request
Feb 26, 2019
…res'. This change is for whatwg/html#4324, and a follow-up of #15123 Bug: crbug.com/905922 Change-Id: I3eceb5d21ab555c23ed877ded17d359fe004e2aa Reviewed-on: https://chromium-review.googlesource.com/c/1482361 Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by: Hayato Ito <hayato@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#635380}
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Feb 26, 2019
…res'. This change is for whatwg/html#4324, and a follow-up of web-platform-tests/wpt#15123 Bug: crbug.com/905922 Change-Id: I3eceb5d21ab555c23ed877ded17d359fe004e2aa Reviewed-on: https://chromium-review.googlesource.com/c/1482361 Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by: Hayato Ito <hayato@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#635380}
chromium-wpt-export-bot
pushed a commit
that referenced
this pull request
Feb 26, 2019
…res'. This change is for whatwg/html#4324, and a follow-up of #15123 Bug: crbug.com/905922 Change-Id: I3eceb5d21ab555c23ed877ded17d359fe004e2aa Reviewed-on: https://chromium-review.googlesource.com/c/1482361 Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by: Hayato Ito <hayato@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#635380}
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Mar 15, 2019
…istry.html for 'disabledFeatures'., a=testonly Automatic update from web-platform-tests custom-elements: Update CustomElementRegistry.html for 'disabledFeatures'. This change is for whatwg/html#4324, and a follow-up of web-platform-tests/wpt#15123 Bug: crbug.com/905922 Change-Id: I3eceb5d21ab555c23ed877ded17d359fe004e2aa Reviewed-on: https://chromium-review.googlesource.com/c/1482361 Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by: Hayato Ito <hayato@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#635380} -- wpt-commits: 1aa5413b0c0a03d3c93e07d18bf8cc78e19ca611 wpt-pr: 15516
mykmelez
pushed a commit
to mykmelez/gecko
that referenced
this pull request
Mar 16, 2019
…istry.html for 'disabledFeatures'., a=testonly Automatic update from web-platform-tests custom-elements: Update CustomElementRegistry.html for 'disabledFeatures'. This change is for whatwg/html#4324, and a follow-up of web-platform-tests/wpt#15123 Bug: crbug.com/905922 Change-Id: I3eceb5d21ab555c23ed877ded17d359fe004e2aa Reviewed-on: https://chromium-review.googlesource.com/c/1482361 Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by: Hayato Ito <hayato@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#635380} -- wpt-commits: 1aa5413b0c0a03d3c93e07d18bf8cc78e19ca611 wpt-pr: 15516
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Mar 16, 2019
…istry.html for 'disabledFeatures'., a=testonly Automatic update from web-platform-tests custom-elements: Update CustomElementRegistry.html for 'disabledFeatures'. This change is for whatwg/html#4324, and a follow-up of web-platform-tests/wpt#15123 Bug: crbug.com/905922 Change-Id: I3eceb5d21ab555c23ed877ded17d359fe004e2aa Reviewed-on: https://chromium-review.googlesource.com/c/1482361 Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by: Hayato Ito <hayato@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#635380} -- wpt-commits: 1aa5413b0c0a03d3c93e07d18bf8cc78e19ca611 wpt-pr: 15516
mykmelez
pushed a commit
to mykmelez/gecko
that referenced
this pull request
Mar 17, 2019
…istry.html for 'disabledFeatures'., a=testonly Automatic update from web-platform-tests custom-elements: Update CustomElementRegistry.html for 'disabledFeatures'. This change is for whatwg/html#4324, and a follow-up of web-platform-tests/wpt#15123 Bug: crbug.com/905922 Change-Id: I3eceb5d21ab555c23ed877ded17d359fe004e2aa Reviewed-on: https://chromium-review.googlesource.com/c/1482361 Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by: Hayato Ito <hayato@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#635380} -- wpt-commits: 1aa5413b0c0a03d3c93e07d18bf8cc78e19ca611 wpt-pr: 15516
domenic
pushed a commit
to whatwg/html
that referenced
this pull request
May 16, 2019
This provides the ElementInternals interface, which can be obtained for custom elements via the element.attachInternals() method. For now ElementInternals is empty, but it will gain members in #4383. This also adds the ability for custom elements to set the disabledFeatures static property, to disable element internals and shadow DOM. Some DOM-side infrastructure work there is necessary in whatwg/dom#760. Tests: - web-platform-tests/wpt#15123 - web-platform-tests/wpt#15516 - web-platform-tests/wpt#16853 Fixes WICG/webcomponents#758.
marcoscaceres
pushed a commit
that referenced
this pull request
Jul 23, 2019
marcoscaceres
pushed a commit
that referenced
this pull request
Jul 23, 2019
…res'. This change is for whatwg/html#4324, and a follow-up of #15123 Bug: crbug.com/905922 Change-Id: I3eceb5d21ab555c23ed877ded17d359fe004e2aa Reviewed-on: https://chromium-review.googlesource.com/c/1482361 Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by: Hayato Ito <hayato@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#635380}
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 4, 2019
…istry.html for 'disabledFeatures'., a=testonly Automatic update from web-platform-tests custom-elements: Update CustomElementRegistry.html for 'disabledFeatures'. This change is for whatwg/html#4324, and a follow-up of web-platform-tests/wpt#15123 Bug: crbug.com/905922 Change-Id: I3eceb5d21ab555c23ed877ded17d359fe004e2aa Reviewed-on: https://chromium-review.googlesource.com/c/1482361 Auto-Submit: Kent Tamura <tkentchromium.org> Reviewed-by: Hayato Ito <hayatochromium.org> Commit-Queue: Kent Tamura <tkentchromium.org> Cr-Commit-Position: refs/heads/master{#635380} -- wpt-commits: 1aa5413b0c0a03d3c93e07d18bf8cc78e19ca611 wpt-pr: 15516 UltraBlame original commit: 91b75e0e8324befa1731b448285c8bcc9411d410
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 4, 2019
…istry.html for 'disabledFeatures'., a=testonly Automatic update from web-platform-tests custom-elements: Update CustomElementRegistry.html for 'disabledFeatures'. This change is for whatwg/html#4324, and a follow-up of web-platform-tests/wpt#15123 Bug: crbug.com/905922 Change-Id: I3eceb5d21ab555c23ed877ded17d359fe004e2aa Reviewed-on: https://chromium-review.googlesource.com/c/1482361 Auto-Submit: Kent Tamura <tkentchromium.org> Reviewed-by: Hayato Ito <hayatochromium.org> Commit-Queue: Kent Tamura <tkentchromium.org> Cr-Commit-Position: refs/heads/master{#635380} -- wpt-commits: 1aa5413b0c0a03d3c93e07d18bf8cc78e19ca611 wpt-pr: 15516 UltraBlame original commit: e89bf41687f50e862ace8bb7077aaa06e2f6a8b9
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 4, 2019
…istry.html for 'disabledFeatures'., a=testonly Automatic update from web-platform-tests custom-elements: Update CustomElementRegistry.html for 'disabledFeatures'. This change is for whatwg/html#4324, and a follow-up of web-platform-tests/wpt#15123 Bug: crbug.com/905922 Change-Id: I3eceb5d21ab555c23ed877ded17d359fe004e2aa Reviewed-on: https://chromium-review.googlesource.com/c/1482361 Auto-Submit: Kent Tamura <tkentchromium.org> Reviewed-by: Hayato Ito <hayatochromium.org> Commit-Queue: Kent Tamura <tkentchromium.org> Cr-Commit-Position: refs/heads/master{#635380} -- wpt-commits: 1aa5413b0c0a03d3c93e07d18bf8cc78e19ca611 wpt-pr: 15516 UltraBlame original commit: 91b75e0e8324befa1731b448285c8bcc9411d410
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 4, 2019
…istry.html for 'disabledFeatures'., a=testonly Automatic update from web-platform-tests custom-elements: Update CustomElementRegistry.html for 'disabledFeatures'. This change is for whatwg/html#4324, and a follow-up of web-platform-tests/wpt#15123 Bug: crbug.com/905922 Change-Id: I3eceb5d21ab555c23ed877ded17d359fe004e2aa Reviewed-on: https://chromium-review.googlesource.com/c/1482361 Auto-Submit: Kent Tamura <tkentchromium.org> Reviewed-by: Hayato Ito <hayatochromium.org> Commit-Queue: Kent Tamura <tkentchromium.org> Cr-Commit-Position: refs/heads/master{#635380} -- wpt-commits: 1aa5413b0c0a03d3c93e07d18bf8cc78e19ca611 wpt-pr: 15516 UltraBlame original commit: e89bf41687f50e862ace8bb7077aaa06e2f6a8b9
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 4, 2019
…istry.html for 'disabledFeatures'., a=testonly Automatic update from web-platform-tests custom-elements: Update CustomElementRegistry.html for 'disabledFeatures'. This change is for whatwg/html#4324, and a follow-up of web-platform-tests/wpt#15123 Bug: crbug.com/905922 Change-Id: I3eceb5d21ab555c23ed877ded17d359fe004e2aa Reviewed-on: https://chromium-review.googlesource.com/c/1482361 Auto-Submit: Kent Tamura <tkentchromium.org> Reviewed-by: Hayato Ito <hayatochromium.org> Commit-Queue: Kent Tamura <tkentchromium.org> Cr-Commit-Position: refs/heads/master{#635380} -- wpt-commits: 1aa5413b0c0a03d3c93e07d18bf8cc78e19ca611 wpt-pr: 15516 UltraBlame original commit: 91b75e0e8324befa1731b448285c8bcc9411d410
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 4, 2019
…istry.html for 'disabledFeatures'., a=testonly Automatic update from web-platform-tests custom-elements: Update CustomElementRegistry.html for 'disabledFeatures'. This change is for whatwg/html#4324, and a follow-up of web-platform-tests/wpt#15123 Bug: crbug.com/905922 Change-Id: I3eceb5d21ab555c23ed877ded17d359fe004e2aa Reviewed-on: https://chromium-review.googlesource.com/c/1482361 Auto-Submit: Kent Tamura <tkentchromium.org> Reviewed-by: Hayato Ito <hayatochromium.org> Commit-Queue: Kent Tamura <tkentchromium.org> Cr-Commit-Position: refs/heads/master{#635380} -- wpt-commits: 1aa5413b0c0a03d3c93e07d18bf8cc78e19ca611 wpt-pr: 15516 UltraBlame original commit: e89bf41687f50e862ace8bb7077aaa06e2f6a8b9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: WICG/webcomponents#758
Specification PR: whatwg/html#4324