-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HTML: ensure BarProps are visible for noopener/noreferrer #16330
Conversation
@bzbarsky so I thought this would be an easy way to test whatwg/html#3297, but Chrome passes the test for noopener, so... |
Yeah, I have no idea what's going on here. The visual display in Chome is the same whether I pass @npm1 any idea what's going on here? |
Nope, this is something the DOM team could dig into. You can contact them at their Chromium email: dom-dev. |
Though I don't know the details, according to crbug.com/310691, Chrome always returns true for BarProp.visible. |
@tkent-google I get |
Sorry for my previous useless comment. |
Okay, so this would show the issue, once that's fixed. Another thing I could potentially assert is viewport width. That is, requiring it to be identical to the opener. I'm not sure how ideal that is though. Thoughts? |
@tkent-google can I assign this over to you for review? Sounds like you have more context than me. (I was picked at random by the bot.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current test doesn't work well only on Chrome due to the Chrome bug, but the test makes sense on other browsers. We fixed the noopener-popup issue of Chrome yesterday, and we have a non-WPT tests. So I think it's ok to merge this as is.
I filed the BarProp issue of Chrome; https://bugs.chromium.org/p/chromium/issues/detail?id=954033 |
Otherwise CSSOM will assume it's more than a new window and treat it like a popup or some such. Helps with #1902. Tests: web-platform-tests/wpt#16330 & web-platform-tests/wpt#16658.
For whatwg/html#3297.