Submissions/tomoyukilabs

[tomoyukilabs]

Several tests for are added:

• the value attribute is out of the range between min and max
• min > max
• confirming if step scale factor becomes integer or not
• solving the step mismatch
• stepUp() and stepDown() methods
  ...etc.

[odinho]

Maybe a <div style=display:none> to wrap around instead?

[tomoyukilabs]

Sound good. Thanks.

[odinho]

For readability, I think all of these could rather be using more lines. Let the assert_equals at least get its own line.

[odinho]

Also, having so many inputs, and then using array indeces like this to get the relevant input element makes it a bit hard to update the test. Though I regard it as style issue, but it'd definitely be better not to have that problem. :)

[odinho]

For readability, the contents of the function should be indented with four spaces. It's a bit messy to tell what's going on here now. Like this:

test(function() {
    var e = document...
    assert_equals(... "9")
}, "Performing stepUp()",
{ "help": "http://..." }

[odinho]

This is a good improvement with more tests here!

I have some style issues though ;-) Also, it'd be cool to have some non-integer steps added in there.

[odinho]

Are you finished? This look good to me, the hunting of list indeces-to-actually-input-elements can be fixed later. Better to get stuff in.

[tomoyukilabs]

Now I'm adding id attribute to each tags...

[tomoyukilabs]

Finished!

[odinho]

w3c-test:mirror

[odinho]

Thanks! :D Great stuff, very readable now.

[tomoyukilabs]

Thanks so much!