Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shadow-dom: Add testcases for attachShadow() with disabledFeatures=['shadow'] #16795

Merged
merged 4 commits into from
May 16, 2019

Conversation

tkent-google
Copy link
Contributor

Specification PR: whatwg/dom#760

Copy link
Member

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look good, except we should probably wait with landing these until we settle the "which exception should we throw" question I raised in DOM.

@domenic domenic merged commit 7e939f6 into master May 16, 2019
@domenic domenic deleted the tkent-disabled-attachShadow branch May 16, 2019 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants