Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix and re-enable web tests affected by Error structured cloning #17872

Merged
merged 1 commit into from
Jul 18, 2019
Merged

Fix and re-enable web tests affected by Error structured cloning #17872

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion animation-worklet/stateful-animator.https.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@
effect.localTime = this.test_local_time++;
}
state() {
return new Error('foo');
return new Symbol('foo');
}
});
</script>
Expand Down
7 changes: 3 additions & 4 deletions html/browsers/history/the-history-interface/001.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,11 +175,10 @@
}, 'pushState must not be able to use a DOM node as data');
test(function () {
try { a.b = c; } catch(errdata) {
assert_throws( 'DATA_CLONE_ERR', function () {
history.pushState({dummy:errdata},'');
} );
history.pushState({dummy:errdata},'');
assert_equals(ReferenceError.prototype, Object.getPrototypeOf(history.state.dummy));
}
}, 'pushState must not be able to use an error object as data');
}, 'pushState must be able to use an error object as data');
test(function () {
assert_throws( 'DATA_CLONE_ERR', function () {
iframe.contentWindow.history.pushState(document,'');
Expand Down
7 changes: 3 additions & 4 deletions html/browsers/history/the-history-interface/002.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,11 +156,10 @@
}, 'replaceState must not be able to use a DOM node as data');
test(function () {
try { a.b = c; } catch(errdata) {
assert_throws( 'DATA_CLONE_ERR', function () {
history.replaceState({dummy:errdata},'');
} );
history.replaceState({dummy:errdata},'');
assert_equals(ReferenceError.prototype, Object.getPrototypeOf(history.state.dummy));
}
}, 'replaceState must not be able to use an error object as data');
}, 'replaceState must be able to use an error object as data');
test(function () {
assert_throws( 'DATA_CLONE_ERR', function () {
iframe.contentWindow.history.replaceState(document,'');
Expand Down