Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add triggers/* branches to support triggering full runs #18870

Merged
merged 6 commits into from
Sep 5, 2019
Merged

Add triggers/* branches to support triggering full runs #18870

merged 6 commits into from
Sep 5, 2019

Conversation

foolip
Copy link
Member

@foolip foolip commented Sep 5, 2019

Fixes #13263.

@foolip foolip mentioned this pull request Sep 5, 2019
Closed
@foolip
Copy link
Member Author

foolip commented Sep 5, 2019

I've already created all branches except two of them. To verify that this works, I'll push the head of this PR to the two that remain: firefox_nightly and safari_preview.

@foolip foolip assigned jgraham and unassigned sideshowbarker Sep 5, 2019
@foolip
Copy link
Member Author

foolip commented Sep 5, 2019

STP succesfully triggered: https://dev.azure.com/web-platform-tests/wpt/_build/results?buildId=29824

Taskcluster didn't work, will iterate...

@wpt-pr-bot wpt-pr-bot added the ci label Sep 5, 2019
@foolip
Copy link
Member Author

foolip commented Sep 5, 2019

https://tools.taskcluster.net/groups/Qwz3vIzuQlGW5SWf9JREnQ is looking better, I think this works now.

jgraham
jgraham approved these changes Sep 5, 2019
View reviewed changes
Copy link
Contributor

@jgraham jgraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice approach! Probably doesn't scale to many more configurations, but I think it's fine for our requirements.

@foolip
Copy link
Member Author

foolip commented Sep 5, 2019

https://wpt.fyi/results/?sha=c8ea6db4f7&max-count=1 shows two of the runs successfully triggered by this, so merging now :)

@foolip foolip merged commit d86745d into master Sep 5, 2019
@foolip foolip deleted the foolip/trigger-branches branch September 5, 2019 11:37
@jugglinmike jugglinmike mentioned this pull request Oct 9, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgraham jgraham jgraham approved these changes

@gsnedders gsnedders Awaiting requested review from gsnedders

@sideshowbarker sideshowbarker Awaiting requested review from sideshowbarker

@jugglinmike jugglinmike Awaiting requested review from jugglinmike

Assignees

@jgraham jgraham

Labels
Azure Pipelines ci docs infra
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ability to run all tests for some PRs
4 participants
@foolip @jgraham @sideshowbarker @wpt-pr-bot