Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for the MathML Operator dictionary #19123

Merged
merged 4 commits into from
Sep 18, 2019
Merged

Add tests for the MathML Operator dictionary #19123

merged 4 commits into from
Sep 18, 2019

Conversation

fred-wang
Copy link
Contributor

No description provided.

@wpt-pr-bot
Copy link
Collaborator

There are no reviewers for this pull request besides its author. Please reach out on W3C's irc server (irc.w3.org, port 6665) on channel #testing (web client) to get help with this. Thank you!

@fred-wang
Copy link
Contributor Author

This is still WIP

This was referenced Sep 17, 2019
Closed
Closed
@fred-wang
Add tests for the MathML Operator dictionary
4281274 
Add tests to check largeop, stretchy, symmetric, movablelimits and accent
properties of the MathML operator dictionary.

Also do misc fixes in mathvariant-transforms.py
@fred-wang fred-wang force-pushed the mathml-operator-dictionary branch from 4899144 to 4281274 Compare September 18, 2019 12:38
@fred-wang fred-wang requested review from rwlbuis and removed request for gsnedders, fantasai and kojiishi September 18, 2019 12:40
@fred-wang
Copy link
Contributor Author

This is now ready for review

rwlbuis
rwlbuis reviewed Sep 18, 2019
View reviewed changes
Copy link
Contributor

@rwlbuis rwlbuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems one needs to be lspace and maybe consider reordering.

rwlbuis
rwlbuis approved these changes Sep 18, 2019
View reviewed changes
Copy link
Contributor

@rwlbuis rwlbuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@fred-wang fred-wang closed this Sep 18, 2019
@fred-wang fred-wang reopened this Sep 18, 2019
@jgraham
Copy link
Contributor

jgraham commented Sep 18, 2019

The CI failure is

Slow tests

Test Result Longest duration (ms) Timeout (ms)
/mathml/presentation-markup/operators/operator-dictionary-001.html OK 8143 10000

So this is being detected as a test that could intermittently time out. Ideally we add <meta name=timeout content=long> to the test to avoid the potential instability.

@fred-wang
Copy link
Contributor Author

Thanks will try that

@fred-wang fred-wang merged commit d473076 into master Sep 18, 2019
@fred-wang fred-wang deleted the mathml-operator-dictionary branch September 18, 2019 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwlbuis rwlbuis rwlbuis approved these changes

Assignees

@rwlbuis rwlbuis

Labels
assets mathml status:needs-reviewers wg-math
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@fred-wang @wpt-pr-bot @jgraham @rwlbuis @gsnedders