Add missing worklet referrer tests #19165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Sep 19, 2019
This CL adds more web-platform-tests for the `Referer` on worklet descendant requests. This CL introduces tests where we fetch a same-origin descendant script from a cross-origin worklet script served with varying referrer policies. The tests are similar to those introduced in crrev.com/c/1809205 for module scripts, and will pass once crrev.com/c/1808663 is merged. R=ikilpatrick@chromium.org, kouhei@chromium.org Bug: 786862,1004083 Change-Id: I4425be4264424b52e4ec307513a404541869f2a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1813122 Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/master@{#699351}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1813122
branch
from
46b7af8
to
6dcd308
Compare
|
wpt-firefox-nightly-stability has failed on Taskcluster because of slow tests:
@zcorpan I think this is the first time I've seen this, but it's a good catch! |
They take close to 10 seconds on Firefox: #19165 (comment)
|
Yay! |
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Sep 26, 2019
…stonly Automatic update from web-platform-tests Add missing worklet referrer tests This CL adds more web-platform-tests for the `Referer` on worklet descendant requests. This CL introduces tests where we fetch a same-origin descendant script from a cross-origin worklet script served with varying referrer policies. The tests are similar to those introduced in crrev.com/c/1809205 for module scripts, and will pass once crrev.com/c/1808663 is merged. R=ikilpatrick@chromium.org, kouhei@chromium.org Bug: 786862,1004083 Change-Id: I4425be4264424b52e4ec307513a404541869f2a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1813122 Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/master@{#699351} -- Add long timeout to worklet referrer tests They take close to 10 seconds on Firefox: web-platform-tests/wpt#19165 (comment) -- wpt-commits: 98c89472a9e6359bfac5b40b05188c9c5b39be79, eaa551911f12c5c526f56cafd0c7ab24667ead3c wpt-pr: 19165
xeonchen
pushed a commit
to xeonchen/gecko
that referenced
this pull request
Sep 27, 2019
…stonly Automatic update from web-platform-tests Add missing worklet referrer tests This CL adds more web-platform-tests for the `Referer` on worklet descendant requests. This CL introduces tests where we fetch a same-origin descendant script from a cross-origin worklet script served with varying referrer policies. The tests are similar to those introduced in crrev.com/c/1809205 for module scripts, and will pass once crrev.com/c/1808663 is merged. R=ikilpatrick@chromium.org, kouhei@chromium.org Bug: 786862,1004083 Change-Id: I4425be4264424b52e4ec307513a404541869f2a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1813122 Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/master@{#699351} -- Add long timeout to worklet referrer tests They take close to 10 seconds on Firefox: web-platform-tests/wpt#19165 (comment) -- wpt-commits: 98c89472a9e6359bfac5b40b05188c9c5b39be79, eaa551911f12c5c526f56cafd0c7ab24667ead3c wpt-pr: 19165
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 4, 2019
…stonly Automatic update from web-platform-tests Add missing worklet referrer tests This CL adds more web-platform-tests for the `Referer` on worklet descendant requests. This CL introduces tests where we fetch a same-origin descendant script from a cross-origin worklet script served with varying referrer policies. The tests are similar to those introduced in crrev.com/c/1809205 for module scripts, and will pass once crrev.com/c/1808663 is merged. R=ikilpatrickchromium.org, kouheichromium.org Bug: 786862,1004083 Change-Id: I4425be4264424b52e4ec307513a404541869f2a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1813122 Reviewed-by: Ian Kilpatrick <ikilpatrickchromium.org> Commit-Queue: Dominic Farolino <domchromium.org> Cr-Commit-Position: refs/heads/master{#699351} -- Add long timeout to worklet referrer tests They take close to 10 seconds on Firefox: web-platform-tests/wpt#19165 (comment) -- wpt-commits: 98c89472a9e6359bfac5b40b05188c9c5b39be79, eaa551911f12c5c526f56cafd0c7ab24667ead3c wpt-pr: 19165 UltraBlame original commit: 4b1a16410004641274faf37bbb27a3fca5013a56
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 4, 2019
…stonly Automatic update from web-platform-tests Add missing worklet referrer tests This CL adds more web-platform-tests for the `Referer` on worklet descendant requests. This CL introduces tests where we fetch a same-origin descendant script from a cross-origin worklet script served with varying referrer policies. The tests are similar to those introduced in crrev.com/c/1809205 for module scripts, and will pass once crrev.com/c/1808663 is merged. R=ikilpatrickchromium.org, kouheichromium.org Bug: 786862,1004083 Change-Id: I4425be4264424b52e4ec307513a404541869f2a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1813122 Reviewed-by: Ian Kilpatrick <ikilpatrickchromium.org> Commit-Queue: Dominic Farolino <domchromium.org> Cr-Commit-Position: refs/heads/master{#699351} -- Add long timeout to worklet referrer tests They take close to 10 seconds on Firefox: web-platform-tests/wpt#19165 (comment) -- wpt-commits: 98c89472a9e6359bfac5b40b05188c9c5b39be79, eaa551911f12c5c526f56cafd0c7ab24667ead3c wpt-pr: 19165 UltraBlame original commit: 4b1a16410004641274faf37bbb27a3fca5013a56
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 5, 2019
…stonly Automatic update from web-platform-tests Add missing worklet referrer tests This CL adds more web-platform-tests for the `Referer` on worklet descendant requests. This CL introduces tests where we fetch a same-origin descendant script from a cross-origin worklet script served with varying referrer policies. The tests are similar to those introduced in crrev.com/c/1809205 for module scripts, and will pass once crrev.com/c/1808663 is merged. R=ikilpatrickchromium.org, kouheichromium.org Bug: 786862,1004083 Change-Id: I4425be4264424b52e4ec307513a404541869f2a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1813122 Reviewed-by: Ian Kilpatrick <ikilpatrickchromium.org> Commit-Queue: Dominic Farolino <domchromium.org> Cr-Commit-Position: refs/heads/master{#699351} -- Add long timeout to worklet referrer tests They take close to 10 seconds on Firefox: web-platform-tests/wpt#19165 (comment) -- wpt-commits: 98c89472a9e6359bfac5b40b05188c9c5b39be79, eaa551911f12c5c526f56cafd0c7ab24667ead3c wpt-pr: 19165 UltraBlame original commit: 4b1a16410004641274faf37bbb27a3fca5013a56
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CL adds more web-platform-tests for the
Refereron workletdescendant requests. This CL introduces tests where we fetch a
same-origin descendant script from a cross-origin worklet script served
with varying referrer policies.
The tests are similar to those introduced in crrev.com/c/1809205 for
module scripts, and will pass once crrev.com/c/1808663 is merged.
R=ikilpatrick@chromium.org, kouhei@chromium.org
Bug: 786862,1004083
Change-Id: I4425be4264424b52e4ec307513a404541869f2a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1813122
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Dominic Farolino <dom@chromium.org>
Cr-Commit-Position: refs/heads/master@{#699351}