Miscellaneous improvements to MathML DOM tests #19534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Don't use asynchronous test to check MathMLElement onevent attributes. closes #19500 - Only test tab-navigation of MathML links when HTML links are tab-navigable. https://github.com/mathml-refresh/mathml/issues/152 https://github.com/Igalia/chromium-dev/issues/50 https://bugzilla.mozilla.org/show_bug.cgi?id=1571487#c30
|
There are no reviewers for this pull request besides its author. Please reach out on W3C's irc server (irc.w3.org, port 6665) on channel #testing (web client) to get help with this. Thank you! |
bzbarsky
reviewed
Oct 5, 2019
| @@ -10,6 +10,7 @@ | |||
| <script src="/resources/testdriver.js"></script> | |||
| <script src="/resources/testdriver-vendor.js"></script> | |||
| <div id="log"></div> | |||
| <a tabindex="1" href="#link">tabindex(1)-html</a> | |||
There was a problem hiding this comment.
Why the tabindex="1" here? The mtext that's a link doesn't have that...
There was a problem hiding this comment.
That was to make the HTML link focused before all the other focusable MathML elements in this test. This explicit tabindex="1" does not make the link tab-navigable on macOS.
However, it's true that we actually only need that HTML link to be focused before the mtext link and removing the tabindex attribute make them more similar. So I'll to remove it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes Don't use asynchronous test to check MathMLElement onevent attributes #19500
https://github.com/mathml-refresh/mathml/issues/152
https://github.com/Igalia/chromium-dev/issues/50
https://bugzilla.mozilla.org/show_bug.cgi?id=1571487#c30