Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support crashtests in testfiles.affected_testfiles #21531

Merged
merged 2 commits into from
Jan 31, 2020
Merged

Support crashtests in testfiles.affected_testfiles #21531

merged 2 commits into from
Jan 31, 2020

Conversation

stephenmcgruer
Copy link
Contributor

No description provided.

@stephenmcgruer stephenmcgruer mentioned this pull request Jan 31, 2020
Merged
@stephenmcgruer stephenmcgruer force-pushed the smcgruer/affected-testfiles branch from 68d6d22 to 3a19ba1 Compare January 31, 2020 15:10
@stephenmcgruer stephenmcgruer force-pushed the smcgruer/affected-testfiles branch from 3a19ba1 to e0e2ede Compare January 31, 2020 15:36
Hexcles
Hexcles approved these changes Jan 31, 2020
View reviewed changes
Copy link
Member

@Hexcles Hexcles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I misread it as msft at first, but mfst is also a bad name...

The test setup is a bit convoluted but I agree with you that this is probably the most reasonable way for now.

tools/wpt/tests/test_testfiles.py Outdated Show resolved Hide resolved
tools/wpt/tests/test_testfiles.py Outdated Show resolved Hide resolved
tools/wpt/tests/test_testfiles.py Outdated Show resolved Hide resolved
@stephenmcgruer @Hexcles
Apply suggestions from code review
4cb9773 
Co-Authored-By: Robert Ma <robertma@chromium.org>
@stephenmcgruer
Copy link
Contributor Author

The 3.8 failure appears to be a network error in TC. Retrying.

@stephenmcgruer stephenmcgruer merged commit c7227ea into master Jan 31, 2020
@stephenmcgruer stephenmcgruer deleted the smcgruer/affected-testfiles branch January 31, 2020 19:30
@jgraham jgraham mentioned this pull request Feb 4, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hexcles Hexcles Hexcles approved these changes

@jgraham jgraham Awaiting requested review from jgraham

@gsnedders gsnedders Awaiting requested review from gsnedders

@jugglinmike jugglinmike Awaiting requested review from jugglinmike

@KyleJu KyleJu Awaiting requested review from KyleJu

@LukeZielinski LukeZielinski Awaiting requested review from LukeZielinski

Assignees

@gsnedders gsnedders

Labels
infra wpt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stephenmcgruer @Hexcles @gsnedders @wpt-pr-bot