Update size.attributes.parse.trailingjunk #22806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Apr 9, 2020
Fix size.attributes.parse.trailingjunk to match spec: offscreenCanvas.width = '100#!?' should shrow TypeError because 100#!? is NaN. Bug: 1067639 Change-Id: I5b9798cfb7d4f7ecfc77854fd1431c1df89f84a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142746 Reviewed-by: Fernando Serboncini <fserb@chromium.org> Commit-Queue: Yi Xu <yiyix@chromium.org> Cr-Commit-Position: refs/heads/master@{#757945}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2142746
branch
from
60492b3 to
b2831bd
Compare
|
Chrome task failed due to network flake (#21529), close-opening to retry |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix size.attributes.parse.trailingjunk to match spec:
offscreenCanvas.width = '100#!?' should shrow TypeError because 100#!?
is NaN.
Bug: 1067639
Change-Id: I5b9798cfb7d4f7ecfc77854fd1431c1df89f84a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142746
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Commit-Queue: Yi Xu <yiyix@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757945}