[css-flexbox] Move negative-margins-assert.html to WPT #22845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Apr 10, 2020
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2144801
branch
from
e53239a to
8269fa6
Compare
This CL migrates this test out of third_party/blink/web_tests/css3/flexbox and into the WPT-specific directory, adding links to the relevant specs and a test assertion describing its purpose and renames it to negative-flex-margins-crash.html. Bug: 1063749 Change-Id: Ibd2006646b62247ec4b0fd77165b7bb5fc058040 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144801 Reviewed-by: David Grogan <dgrogan@chromium.org> Reviewed-by: Robert Ma <robertma@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#758491}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2144801
branch
from
8269fa6 to
5f23150
Compare
|
Stability check failed due to network flake (#21529), retrying |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CL migrates this test out of
third_party/blink/web_tests/css3/flexbox and into the WPT-specific
directory, adding links to the relevant specs and a test assertion
describing its purpose and renames it to
negative-flex-margins-crash.html.
Bug: 1063749
Change-Id: Ibd2006646b62247ec4b0fd77165b7bb5fc058040
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144801
Reviewed-by: David Grogan <dgrogan@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Commit-Queue: Miyoung Shin <myid.shin@igalia.com>
Cr-Commit-Position: refs/heads/master@{#758491}