Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LazyLoad: Fix feature-policy tests #23250

Merged
merged 1 commit into from
Apr 28, 2020
Merged

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Apr 25, 2020

This updates the lazyload attribute as 'loading' with values of auto,
eager and lazy for the feature policy tests.

TBR=hiroshige@chromium.org

Fixed: 1074608
Change-Id: If8ba1d09bce518ac36b70bd2a7b01687ffec87c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166638
Commit-Queue: rajendrant <rajendrant@chromium.org>
Reviewed-by: Scott Little <sclittle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#763010}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2166638 branch 3 times, most recently from 53dec87 to 92b78a1 Compare April 27, 2020 20:23
This updates the lazyload attribute as 'loading' with values of auto,
eager and lazy for the feature policy tests.

TBR=hiroshige@chromium.org

Fixed: 1074608
Change-Id: If8ba1d09bce518ac36b70bd2a7b01687ffec87c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166638
Commit-Queue: rajendrant <rajendrant@chromium.org>
Reviewed-by: Scott Little <sclittle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#763010}
@foolip
Copy link
Member

foolip commented Apr 28, 2020

Taskcluster failed while trying to download https://storage.googleapis.com/chromium-browser-snapshots/Linux_x64/761185/chromedriver_linux64.zip. That's #21529 which might be fixed now.

I'll admin merge since the results of wpt-chrome-dev-results-without-changes wouldn't block this anyway, and the test came from Chromium to begin with.

@foolip foolip merged commit ddad50b into master Apr 28, 2020
@foolip foolip deleted the chromium-export-cl-2166638 branch April 28, 2020 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants