Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use same/cross-site terminology for split cache WPT and minor changes #24173

Merged
merged 1 commit into from
Jun 23, 2020

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Jun 16, 2020

Changes the use of same/cross-origin to same/cross-site to reflect the
change in the approach. Accordingly, names helper files more
appropriately. Also makes the ordering of tests more natural and adds
descriptive names to each test.

Bug: 1092991
Change-Id: If9bebebea8b0b51db2d4f8c1c3ab1ddf1e2fb233
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248867
Commit-Queue: Alex Turner <alexmt@chromium.org>
Reviewed-by: Shivani Sharma <shivanisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781090}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2248867 branch 2 times, most recently from c9a2baa to 8b95bae Compare June 22, 2020 23:28
Changes the use of same/cross-origin to same/cross-site to reflect the
change in the approach. Accordingly, names helper files more
appropriately. Also makes the ordering of tests more natural and adds
descriptive names to each test.

Bug: 1092991
Change-Id: If9bebebea8b0b51db2d4f8c1c3ab1ddf1e2fb233
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248867
Commit-Queue: Alex Turner <alexmt@chromium.org>
Reviewed-by: Shivani Sharma <shivanisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781090}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants