Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test entry/incumbent globals for WebAssembly host functions. #24250

Merged
merged 1 commit into from
Jun 24, 2020
Merged

Test entry/incumbent globals for WebAssembly host functions. #24250

merged 1 commit into from
Jun 24, 2020

Conversation

Ms2ger
Copy link
Contributor

@Ms2ger Ms2ger commented Jun 19, 2020

Substantially based on #21206.

Ref: WebAssembly/spec#1184.

@Ms2ger Ms2ger requested a review from domenic June 19, 2020 14:21
@Ms2ger
Copy link
Contributor Author

Ms2ger commented Jun 19, 2020

Spec text to follow.

@wpt-pr-bot wpt-pr-bot requested a deployment to wpt-preview-24250 June 19, 2020 14:28 Pending
domenic
domenic reviewed Jun 19, 2020
View reviewed changes
Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excited to see more exhaustive tests for this madness :). I apologize if any of my review comments are off-base; it's hard to load this all into my head and I might be missing things.

wasm/jsapi/functions/resources/function/function.html Outdated Show resolved Hide resolved
wasm/jsapi/functions/entry-different-function-realm.html Outdated Show resolved Hide resolved
wasm/jsapi/functions/entry-different-function-realm.html Show resolved Hide resolved
wasm/jsapi/functions/entry.html Outdated Show resolved Hide resolved
Ms2ger
Ms2ger commented Jun 19, 2020
View reviewed changes
Copy link
Contributor Author

@Ms2ger Ms2ger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review! Will address your other comments next week.

Note also https://bugs.chromium.org/p/chromium/issues/detail?id=1096558

wasm/jsapi/functions/entry-different-function-realm.html Outdated Show resolved Hide resolved
@wpt-pr-bot wpt-pr-bot requested a deployment to wpt-preview-24250 June 19, 2020 16:08 Pending
@wpt-pr-bot wpt-pr-bot requested a review from titzer June 22, 2020 14:01
@wpt-pr-bot wpt-pr-bot had a problem deploying to wpt-preview-24250 June 22, 2020 14:20 Error
domenic
domenic approved these changes Jun 22, 2020
View reviewed changes
Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff; this all looks good (and appropriately analogous to the promise tests) to me.

@wpt-pr-bot wpt-pr-bot requested a deployment to wpt-preview-24250 June 23, 2020 10:11 Pending
@Ms2ger Ms2ger merged commit 7fd07ec into master Jun 24, 2020
@Ms2ger Ms2ger deleted the wasm-incumbent branch June 24, 2020 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domenic domenic domenic approved these changes

@titzer titzer Awaiting requested review from titzer

Assignees

@titzer titzer

Labels
wasm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Ms2ger @domenic @titzer @wpt-pr-bot