Add tests for transferable streams #24546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Streams Standard change whatwg/streams#1053 adds the ability to transfer streams to a different realm using postMessage(). Add tests for this feature.
3 tasks
When a TransformStream fails to be transferred because one side is locked, the other side should remain unlocked. Verify this.
wpt-pr-bot
requested review from
domenic,
wanderview,
youennf and
yutakahirano
1 task
|
@domenic Could you take a look at this? |
domenic
approved these changes
Oct 6, 2020
| @@ -0,0 +1,121 @@ | |||
| 'use strict'; | |||
|
|
|||
| // Create a ReadableStream that will pass the tests in | |||
There was a problem hiding this comment.
Nit: in other helper files I've preferred to use self.X = ... to make it clearer what is exported. Possibly even hiding non-exported values inside a closure, like https://github.com/web-platform-tests/wpt/blob/master/streams/resources/rs-utils.js does.
There was a problem hiding this comment.
I will fix this in a follow-up change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Streams Standard change whatwg/streams#1053
adds the ability to transfer streams to a different realm using
postMessage(). Add tests for this feature.