Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Streams: fix interceptThen assigning to a const #24729

Merged
merged 1 commit into from
Jul 24, 2020
Merged

Streams: fix interceptThen assigning to a const #24729

merged 1 commit into from
Jul 24, 2020

Conversation

MattiasBuelens
Copy link
Contributor

@MattiasBuelens MattiasBuelens commented Jul 23, 2020 •
edited
Loading

We try to modify callCount on line 14, so it cannot be a const.

domenic
domenic approved these changes Jul 23, 2020
View reviewed changes
Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did this not get caught? I guess maybe the error only triggers for implementations that fail the test?

@MattiasBuelens
Copy link
Contributor Author

I think so. I only noticed while trying to set up the Node WPT runner for nodejs/whatwg-stream#1, which still fails on a lot of Streams tests.

@domenic domenic merged commit c11b9a7 into web-platform-tests:master Jul 24, 2020
@MattiasBuelens MattiasBuelens deleted the streams-fix-intercept-then branch July 24, 2020 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domenic domenic domenic approved these changes

@ricea ricea Awaiting requested review from ricea

@wanderview wanderview Awaiting requested review from wanderview

@youennf youennf Awaiting requested review from youennf

@yutakahirano yutakahirano Awaiting requested review from yutakahirano

Assignees

@yutakahirano yutakahirano

Labels
streams
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MattiasBuelens @domenic @yutakahirano @wpt-pr-bot