[WPT] Errors caught/reported for importScripts() #24810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jul 30, 2020
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2327787
branch
from
f2f1e61 to
c15536e
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2327787
branch
3 times, most recently
from
7802ded to
b09fdeb
Compare
chromium-wpt-export-bot
changed the title
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2327787
branch
7 times, most recently
from
d937b49 to
611d9fc
Compare
This CL adds WPTs for exceptions in importScripts() captured by - WorkerGlobalScope error event handler or - try/catch. Some of the tests are migrated from non-WPT web_tests. The tests are failing on Chromium right now, and will pass after https://chromium-review.googlesource.com/c/chromium/src/+/2328394/. Bug: 1111134, 1111750, 795636 Change-Id: Ie19085171261d4baf307b6544ff6a8da1a8e9041 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327787 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by: Domenic Denicola <domenic@chromium.org> Reviewed-by: Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/master@{#794474}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2327787
branch
from
611d9fc to
2b784f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CL adds WPTs for exceptions in importScripts() captured by
Some of the tests are migrated from non-WPT web_tests.
The tests are failing on Chromium right now, and will pass
after
https://chromium-review.googlesource.com/c/chromium/src/+/2328394/.
Bug: 1111134, 1111750, 795636
Change-Id: Ie19085171261d4baf307b6544ff6a8da1a8e9041
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327787
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Domenic Denicola <domenic@chromium.org>
Reviewed-by: Dominic Farolino <dom@chromium.org>
Cr-Commit-Position: refs/heads/master@{#794474}