-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace ===/!== in assert_true/false #25086
Conversation
This change is too large. I have no idea what part of it @wpt-pr-bot wants me to look at. |
wpt-pr-bot uses 'reviewers' as a cc list (because GitHub has basically no support for cc... there is a very stalled RFC to change how wpt-pr-bot works here), so you are not necessarily expected to review this. GitHub uses 'assignees' for what Chromium calls 'reviewers'. That said, it looks like you are listed as an owner for 5 directories:
So for this PR, (I do not disagree that this is a large and wide PR, and wpt-pr-bot does a bad job for large, wide PRs.) Overall, for this PR I am most interested in whether @jan-ivar is happy with the new version (and thanks to @gsnedders for taking on this refactor!) |
LGTM again. I understand there is some risk of changed semantics here, but with the removal of most of the controversial cases I think this is a net positive change for the test suite. I took a look at the Chrome, Firefox, and Safari results. Chrome and Firefox had no different results before/after at all. Safari had a few:
Please give 24 hours for someone to raise a new objection, otherwise LGTM to merge. |
Co-authored-by: Jan-Ivar Bruaroey <jan-ivar@users.noreply.github.com>
e59aba1
to
21e54ff
Compare
Refs: web-platform-tests/wpt#25086 PR-URL: #35329 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Shingo Inoue <leko.noor@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Refs: web-platform-tests/wpt#25086 PR-URL: nodejs#35329 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Shingo Inoue <leko.noor@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
This is relatively common and this does some of the simple cases that I can easily replace with regex.