WPT: Refactor contacts tests to use test-only-api.js #25421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Sep 7, 2020
chromium-wpt-export-bot
changed the title
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2395395
branch
2 times, most recently
from
2eaba85 to
02100ad
Compare
use of test-only-api.js in preparation for launching official MojoJS support in WPT. This would not change the test results on Chromium waterfall (everything should continue to pass) or upstream WPT (tests currently fail because MojoJS isn't enabled). Bug: 1123989 Change-Id: Ib7fed092b37243b82fbbf38d871bb75728cb7744 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2395395 Commit-Queue: Arnaud Mandy <arnaud.mandy@intel.com> Reviewed-by: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#805272}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2395395
branch
from
02100ad to
b5ae0d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use of test-only-api.js in preparation for launching official MojoJS support
in WPT. This would not change the test results on Chromium waterfall
(everything should continue to pass) or upstream WPT (tests currently
fail because MojoJS isn't enabled).
Bug: 1123989
Change-Id: Ib7fed092b37243b82fbbf38d871bb75728cb7744
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2395395
Commit-Queue: Arnaud Mandy <arnaud.mandy@intel.com>
Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#805272}