Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python3: Remove xfail for wpt unit tests in PY3 #26202

Merged
merged 2 commits into from
Oct 21, 2020
Merged

Python3: Remove xfail for wpt unit tests in PY3 #26202

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
68f1cfb
Python3: Remove xfail for wpt unit tests in PY3
ziransun Oct 21, 2020
ce0e490
Remove unused import
ziransun Oct 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions tools/wpt/tests/test_wpt.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import errno
import os
import platform
import shutil
import socket
import subprocess
Expand Down Expand Up @@ -44,9 +43,6 @@ def get_persistent_manifest_path():

@pytest.fixture(scope="module", autouse=True)
def init_manifest():
# See https://github.com/pypa/virtualenv/issues/1710
if sys.version_info[0] >= 3 and platform.system() == "Windows":
ziransun marked this conversation as resolved.
Show resolved Hide resolved
pytest.xfail(reason="virtualenv activation fails in Windows for python3")
with pytest.raises(SystemExit) as excinfo:
wpt.main(argv=["manifest", "--no-download",
"--path", get_persistent_manifest_path()])
Expand Down