Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update declarative Shadow DOM opt-in mechanics #26482

Merged
merged 1 commit into from
Nov 12, 2020

Commits on Nov 12, 2020

  1. Update declarative Shadow DOM opt-in mechanics

    The issue thread [1] has had more discussion, after the initial draft
    of declarative Shadow DOM opt-in landed [2]. This CL implements those
    bits of feedback. In particular:
     - There is no public allowDeclarativeShadowDom state available on
       Document or DocumentFragment.
     - All APIs use call parameters to avoid state, with the exception
       of DOMParser.
     - innerHTML no longer supports Declarative Shadow DOM.
     - A new setInnerHTML() function allows opt-in access to DSD.
     - Several of the more obscure APIs do not have an opt-in for
       declarative Shadow DOM, such as XHR, createContextualFragment, and
       document.write.
     - The sandbox flag has been removed from iframes completely. The new
       plan is to use DocumentPolicy to enable declarative Shadow DOM for
       iframes. For now, iframes always support declarative Shadow DOM.
     - 'allowDeclarativeShadowDOM' has become 'allowShadowRoot'.
    
    [1] whatwg/dom#912 (comment)
    [2] https://chromium-review.googlesource.com/c/chromium/src/+/2513525
    
    Bug: 1042130
    
    Change-Id: I3a2becf2a113cc8647b29077d2efea1c990d4547
    Cq-Do-Not-Cancel-Tryjobs: true
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530222
    Auto-Submit: Mason Freed <masonfreed@chromium.org>
    Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
    Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
    Commit-Queue: Mason Freed <masonfreed@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#826643}
    mfreed7 authored and chromium-wpt-export-bot committed Nov 12, 2020
    Configuration menu
    Copy the full SHA
    7c8d723 View commit details
    Browse the repository at this point in the history