Service worker: Fail if fetch event has targetClientId #29213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Discussion w3c/ServiceWorker#1333 (comment) |
|
Rather than introducing a failure in an existing test, how about a |
|
Heh yeah, that is simpler |
foolip
reviewed
Jun 7, 2021
| @@ -17,6 +17,8 @@ | |||
| const registration = | |||
| await service_worker_unregister_and_register(t, worker, scope); | |||
| await wait_for_state(t, registration.installing, 'activated'); | |||
|
|
|||
| // This will happen after all other tests | |||
There was a problem hiding this comment.
Do you want to keep this comment, or revert that too?
There was a problem hiding this comment.
I'd like to keep that if that's ok. It confused me when reading those tests.
There was a problem hiding this comment.
That's fine, just making sure it was intentional.
foolip
approved these changes
Jun 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On
FetchEvent,targetClientIdwas renamed toreplacesClientId. Unfortunately Safari shippedtargetClientIdbefore we made the change, and didn't realise due to some miscommunication.This test fails in browsers that have
targetClientId.Unfortunately there aren't any proper tests for
replacesClientId(ortargetClientId), but that's for another day.