Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-text] Fix ID and PR rules. #29781

Merged
merged 1 commit into from
Jul 29, 2021

Conversation

makotokato
Copy link
Member

css-text-line-break--pr-.html tests seems to be break opportunity tests for
PR and ID. But according to UAX #14, This rules are ID ÷ PR × ID. So these
are incorrect.

css-text-line-break-de-pr-*.html tests seems to be break opportunity tests for
PR and ID. But according to UAX web-platform-tests#14, This rules are ID ÷ PR × ID. So these are
incorrect.
@makotokato
Copy link
Member Author

cc: @r12a
I was already asking Richard about this. Then I moved this to github.

Copy link
Contributor

@kojiishi kojiishi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you!

@aethanyc aethanyc merged commit 84330c9 into web-platform-tests:master Jul 29, 2021
@makotokato makotokato deleted the id-pr-id branch January 19, 2022 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants