#23253 Lint for valid CSS flags #31588
Conversation
|
It looks like the documentation build failing might be related to this issue here since the same warning is showing and we are using docutils-0.18. The |
| 'should', | ||
| 'svg' | ||
| }), | ||
| 'deprecated': frozenset({ |
There was a problem hiding this comment.
How many of these do we have? Can they be removed instead of adding them to the lint?
There was a problem hiding this comment.
Based on this run we have:
INFO:lint:There were 6907 errors (DEPRECATED-CSS-REQUIREMENT-FLAG: 1066 INVALID-CSS-REQUIREMENT-FLAG: 5841)
We can begin removing the invalid or deprecated flags as well. If we remove the existing flags, would it not be worth keeping a check in the lint to make sure no more invalid flags are added?
|
This change will require a larger cleanup of the flags currently in the repository to be landed, and with that comes more work that will require further planning. This is a low-priority change with a high amount of work involved. Closing this for now. |
#23253
Running the lint will now check the CSS flags in the source file and check if they are valid or deprecated. If any are found that are invalid, the lint will now show an error and ask for a fix. This check is only done for test in the
css/directory.CSS requirement flags pulled from the docs here.