Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve a slot element's directionality from the flattened tree #32108

Closed
wants to merge 1 commit into from

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Dec 16, 2021

This CL applies the new agreements for a <slot> element on the
standards meeting[1][2].

  • Resolve the slot element's directionality from the flattened tree
  • Apply one exception that the slot element's directionality should
    be the same as a shadow host's directionality if the slot element
    has a dir=auto attribute and has no slotted content.

This CL adds the unit tests on blink and WPT tests will be added on [3].

[1] whatwg/html#7299
[2] whatwg/html#3699 (comment)
[3] #29820

Bug: 1236384
Change-Id: I43ca7351fc4d65dd4f72fe4f9627ffa5382e5c20
Reviewed-on: https://chromium-review.googlesource.com/3343556
WPT-Export-Revision: cec8ee092ba6e5b2efb580e28823a640d50b707e

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-3343556 branch 3 times, most recently from 932348b to aea9e11 Compare January 18, 2022 06:34
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-3343556 branch 2 times, most recently from 1dacbe0 to 565b3f7 Compare January 20, 2022 07:50
This CL applies the new agreements for a <slot> element on the
standards meeting[1][2].
 - Resolve the slot element's directionality from the flattened tree
 - Apply one exception that the slot element's directionality should
   be the same as a shadow host's directionality if the slot element
   has a dir=auto attribute and has no slotted content.

This CL adds the unit tests on blink and WPT tests will be added on [3].

[1] whatwg/html#7299
[2] whatwg/html#3699 (comment)
[3] #29820

Bug: 1236384
Change-Id: I43ca7351fc4d65dd4f72fe4f9627ffa5382e5c20
@chromium-wpt-export-bot
Copy link
Collaborator Author

Close this PR because the Chromium CL has been abandoned.

@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-3343556 branch January 18, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants